no-eval

a-tarasyuk · a-tarasyuk · commit 1cc0ff22c1a7 · 2019-06-14T10:25:02.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -83,7 +83,7 @@
         "no-duplicate-case": "error",
         "no-duplicate-imports": "error",
         "no-empty": "error",
-        "no-eval": "off",
+        "no-eval": "error",
         "no-extra-bind": "error",
         "no-fallthrough": "off",
         "no-invalid-this": "off",
diff --git a/src/harness/evaluator.ts b/src/harness/evaluator.ts
@@ -56,7 +56,7 @@ namespace evaluator {
         }
 
         const evaluateText = `(function (module, exports, require, __dirname, __filename, ${globalNames.join(", ")}) { ${output.text} })`;
-        // tslint:disable-next-line:no-eval
+        // eslint-disable-next-line no-eval
         const evaluateThunk = eval(evaluateText) as (module: any, exports: any, require: (id: string) => any, dirname: string, filename: string, ...globalArgs: any[]) => void;
         const module: { exports: any; } = { exports: {} };
         evaluateThunk.call(globals, module, module.exports, noRequire, vpath.dirname(output.file), output.file, FakeSymbol, ...globalArgs);
@@ -66,4 +66,4 @@ namespace evaluator {
     export function evaluateTypeScript(sourceText: string, options?: ts.CompilerOptions, globals?: Record<string, any>) {
         return evaluate(compile(sourceText, options), globals);
     }
-}
+}
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -3193,7 +3193,7 @@ ${code}
             const debug = new FourSlashInterface.Debug(state);
             const format = new FourSlashInterface.Format(state);
             const cancellation = new FourSlashInterface.Cancellation(state);
-            // tslint:disable-next-line:no-eval
+            // eslint-disable-next-line no-eval
             const f = eval(wrappedCode);
             f(test, goTo, plugins, verify, edit, debug, format, cancellation, FourSlashInterface.Classification, FourSlashInterface.Completion, verifyOperationIsCancelled);
         }

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ namespace evaluator {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	const evaluateText = `(function (module, exports, require, __dirname, __filename, ${globalNames.join(", ")}) { ${output.text} })`;
`59`		`- // tslint:disable-next-line:no-eval`
	`59`	`+ // eslint-disable-next-line no-eval`
`60`	`60`	`const evaluateThunk = eval(evaluateText) as (module: any, exports: any, require: (id: string) => any, dirname: string, filename: string, ...globalArgs: any[]) => void;`
`61`	`61`	`const module: { exports: any; } = { exports: {} };`
`62`	`62`	`evaluateThunk.call(globals, module, module.exports, noRequire, vpath.dirname(output.file), output.file, FakeSymbol, ...globalArgs);`
`@@ -66,4 +66,4 @@ namespace evaluator {`
`66`	`66`	`export function evaluateTypeScript(sourceText: string, options?: ts.CompilerOptions, globals?: Record<string, any>) {`
`67`	`67`	`return evaluate(compile(sourceText, options), globals);`
`68`	`68`	`}`
`69`		`-}`
	`69`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -3193,7 +3193,7 @@ ${code}`
`3193`	`3193`	`const debug = new FourSlashInterface.Debug(state);`
`3194`	`3194`	`const format = new FourSlashInterface.Format(state);`
`3195`	`3195`	`const cancellation = new FourSlashInterface.Cancellation(state);`
`3196`		`- // tslint:disable-next-line:no-eval`
	`3196`	`+ // eslint-disable-next-line no-eval`
`3197`	`3197`	`const f = eval(wrappedCode);`
`3198`	`3198`	`f(test, goTo, plugins, verify, edit, debug, format, cancellation, FourSlashInterface.Classification, FourSlashInterface.Completion, verifyOperationIsCancelled);`
`3199`	`3199`	`}`