no-empty

a-tarasyuk · a-tarasyuk · commit 123ca0d63942 · 2019-06-14T10:21:51.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -82,7 +82,7 @@
         "no-debugger": "off",
         "no-duplicate-case": "error",
         "no-duplicate-imports": "error",
-        "no-empty": "off",
+        "no-empty": "error",
         "no-eval": "off",
         "no-extra-bind": "error",
         "no-fallthrough": "off",
diff --git a/src/compiler/builder.ts b/src/compiler/builder.ts
@@ -957,7 +957,7 @@ namespace ts {
 
             // When semantic builder asks for diagnostics of the whole program,
             // ensure that all the affected files are handled
-            // tslint:disable-next-line no-empty
+            // eslint-disable-next-line no-empty
             while (getSemanticDiagnosticsOfNextAffectedFile(cancellationToken)) {
             }
 
diff --git a/src/server/session.ts b/src/server/session.ts
@@ -669,7 +669,7 @@ namespace ts.server {
                             msg += `\n\nFile text of ${fileRequest.file}:${indent(text)}\n`;
                         }
                     }
-                    catch { } // tslint:disable-line no-empty
+                    catch { } // eslint-disable-line no-empty
                 }
 
                 if (err.message && err.message.indexOf(`Could not find sourceFile:`) !== -1) {
diff --git a/src/testRunner/unittests/builder.ts b/src/testRunner/unittests/builder.ts
@@ -78,7 +78,7 @@ namespace ts {
             const program = getProgram();
             builderProgram = createEmitAndSemanticDiagnosticsBuilderProgram(program, host, builderProgram);
             const outputFileNames: string[] = [];
-            // tslint:disable-next-line no-empty
+            // eslint-disable-next-line no-empty
             while (builderProgram.emitNextAffectedFile(fileName => outputFileNames.push(fileName))) {
             }
             assert.deepEqual(outputFileNames, fileNames);

Original file line number	Diff line number	Diff line change
`@@ -957,7 +957,7 @@ namespace ts {`
`957`	`957`
`958`	`958`	`// When semantic builder asks for diagnostics of the whole program,`
`959`	`959`	`// ensure that all the affected files are handled`
`960`		`- // tslint:disable-next-line no-empty`
	`960`	`+ // eslint-disable-next-line no-empty`
`961`	`961`	`while (getSemanticDiagnosticsOfNextAffectedFile(cancellationToken)) {`
`962`	`962`	`}`
`963`	`963`
Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,7 @@ namespace ts.server {`
`669`	`669`	msg += `\n\nFile text of ${fileRequest.file}:${indent(text)}\n`;
`670`	`670`	`}`
`671`	`671`	`}`
`672`		`- catch { } // tslint:disable-line no-empty`
	`672`	`+ catch { } // eslint-disable-line no-empty`
`673`	`673`	`}`
`674`	`674`
`675`	`675`	if (err.message && err.message.indexOf(`Could not find sourceFile:`) !== -1) {
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ namespace ts {`
`78`	`78`	`const program = getProgram();`
`79`	`79`	`builderProgram = createEmitAndSemanticDiagnosticsBuilderProgram(program, host, builderProgram);`
`80`	`80`	`const outputFileNames: string[] = [];`
`81`		`- // tslint:disable-next-line no-empty`
	`81`	`+ // eslint-disable-next-line no-empty`
`82`	`82`	`while (builderProgram.emitNextAffectedFile(fileName => outputFileNames.push(fileName))) {`
`83`	`83`	`}`
`84`	`84`	`assert.deepEqual(outputFileNames, fileNames);`