Skip to content

Fix issue #255 #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcanessa merged 2 commits into from
Jan 9, 2020
Merged

Fix issue #255 #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a08835
fix issue #255
donmahallem Jan 9, 2020
a00a3a1
added test to _getReleaseBlocks to handle just one tag too
donmahallem Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/Gren.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ class Gren {
this._validateRequiredTagsExists(tags, this.options.tags);

const releaseDates = this._sortReleasesByDate(await Promise.all(this._getTagDates(tags)));
const selectedTags = (this._getSelectedTags(releaseDates) || [releaseDates[0], releaseDates[1]]);
const selectedTags = (this._getSelectedTags(releaseDates) || (releaseDates.length > 1 ? [releaseDates[0], releaseDates[1]] : releaseDates));

loaded(`Tags found: ${selectedTags.map(({ name }) => name).join(', ')}`);

Expand Down
39 changes: 27 additions & 12 deletions test/Gren.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,17 +610,32 @@ describe('Gren', () => {
});
});

it('_getReleaseBlocks', done => {
gren.options.tags = ['0.12.0', '0.11.0'];
gren._getReleaseBlocks()
.then(releaseBlocks => {
assert.isArray(releaseBlocks, 'The releaseBlocks is an Array');
releaseBlocks.forEach(block => {
assert.hasAllKeys(block, ['id', 'release', 'name', 'published_at', 'body']);
});
done();
})
.catch(err => done(err));
}).timeout(10000);
describe('_getReleaseBlocks', () => {
it('more than one tag', done => {
gren.options.tags = ['0.12.0', '0.11.0'];
gren._getReleaseBlocks()
.then(releaseBlocks => {
assert.isArray(releaseBlocks, 'The releaseBlocks is an Array');
releaseBlocks.forEach(block => {
assert.hasAllKeys(block, ['id', 'release', 'name', 'published_at', 'body']);
});
done();
})
.catch(err => done(err));
}).timeout(10000);

it('just one tag', done => {
gren.options.tags = ['0.11.0'];
gren._getReleaseBlocks()
.then(releaseBlocks => {
assert.isArray(releaseBlocks, 'The releaseBlocks is an Array');
releaseBlocks.forEach(block => {
assert.hasAllKeys(block, ['id', 'release', 'name', 'published_at', 'body']);
});
done();
})
.catch(err => done(err));
}).timeout(10000);
});
});
});