Skip to content

Fix follow and unfollow user #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-rewerts merged 4 commits into from
Jun 17, 2019
Merged

Fix follow and unfollow user #554

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf6b42a
Use username arg for follow and unfollow requests.
CodyGramlich Apr 11, 2019
2072dc8
Added tests for follow and unfollow.
CodyGramlich May 2, 2019
4d3f075
Changed test names and removed a test.
CodyGramlich May 2, 2019
92455bb
Resolve merge conflicts.
CodyGramlich Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added tests for follow and unfollow.
  • Loading branch information
@CodyGramlich
CodyGramlich committed May 2, 2019
commit 2072dc8e80fb544634d924d088dd4dd319f17bd0
72 changes: 67 additions & 5 deletions test/user.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import expect from 'must';

import Github from '../lib/GitHub';
import testUser from './fixtures/user.json';
import {assertSuccessful, assertArray} from './helpers/callbacks';
Expand Down Expand Up @@ -61,14 +63,74 @@ describe('User', function() {
user.listStarredRepos(assertArray(done));
});

it('should follow user', function(done) {
user.follow('ingalls', assertSuccessful(done));
});
describe('following a user', function() {
const userToFollow = 'ingalls';

it('should unfollow user', function(done) {
user.unfollow('ingalls', assertSuccessful(done));
before(function() {
return user.unfollow(userToFollow);
})

it('should follow user', function(done) {
user.follow(userToFollow, assertSuccessful(done, function(err, resp) {
user._request('GET', `/user/following`, null, assertSuccessful(done, function(err, following) {
expect((following.some(user => user['login'] === userToFollow))).to.be.true();
done();
}));
}));
});
});

describe('following yourself', function() {
const userToFollow = testUser.USERNAME;

before(function() {
return user.unfollow(userToFollow);
})

it('should attempt to follow yourself', function(done) {
user.follow(userToFollow, assertSuccessful(done, function(err, resp) {
user._request('GET', `/user/following`, null, assertSuccessful(done, function(err, following) {
expect((following.some(user => user['login'] === userToFollow))).to.be.false();
done();
}));
}));
});
})

describe('unfollowing a user', function(done) {
const userToUnfollow = 'ingalls';

before(function() {
return user.follow(userToUnfollow);
})

it('should attempt to unfollow a user', function(done) {
user.unfollow(userToUnfollow, assertSuccessful(done, function(err, resp) {
user._request('GET', `/user/following`, null, assertSuccessful(done, function(err, following) {
expect((following.some(user => user['login'] === userToUnfollow))).to.be.false();
done();
}));
}));
});
})

describe('unfollowing yourself', function(done) {
const userToUnfollow = testUser.USERNAME;

before(function() {
return user.follow(userToUnfollow);
})

it('should attempt to unfollow yourself', function(done) {
user.unfollow(userToUnfollow, assertSuccessful(done, function(err, resp) {
user._request('GET', `/user/following`, null, assertSuccessful(done, function(err, following) {
expect((following.some(user => user['login'] === userToUnfollow))).to.be.false();
done();
}));
}));
});
})

it('should list the email addresses of the user', function(done) {
user.getEmails(assertSuccessful(done));
});
Expand Down