Skip to content

feature(repository): add listPullRequestReviews #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonBarendse wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Open

feature(repository): add listPullRequestReviews #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feature(repository): add listPullRequestReviews (#454)
  • Loading branch information
@SimonBarendse
SimonBarendse committed Sep 3, 2017
commit 3f9e5a2e4644c1ea8ff3ecaaae6d051f8372f8ff
11 changes: 11 additions & 0 deletions lib/Repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,17 @@ class Repository extends Requestable {
return this._request('GET', `/repos/${this.__fullname}/pulls/${number}/files`, null, cb);
}

/**
* List the reviews of a specific pull request
* @see https://developer.github.com/v3/pulls/reviews/
* @param {number|string} number - the PR you wish to fetch
* @param {Requestable.callback} [cb] - will receive the list of reviews from the API
* @return {Promise} - the promise for the http request
*/
listPullRequestReviews(number, cb) {
return this._request('GET', `/repos/${this.__fullname}/pulls/${number}/reviews`, null, cb);
}

/**
* Compare two branches/commits/repositories
* @see https://developer.github.com/v3/repos/commits/#compare-two-commits
Expand Down
9 changes: 9 additions & 0 deletions test/repository.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,15 @@ describe('Repository', function() {
done();
}));
});

it('should list pullrequest reviews', function(done) {
remoteRepo.listPullRequestReviews(454, assertSuccessful(done, function(err, reviews) {
expect(reviews).to.be.an.array();
expect(reviews[0]).to.have.own('body', 'Please add tests for this');

done();
}));
});
});

describe('creating/modifiying', function() {
Expand Down