Skip to content

Rate limit errors #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clayreimann merged 8 commits into from
Jun 22, 2016
Merged

Rate limit errors #354

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3926b99
Add request/response fixture data for rate limit
divergentdave Jun 18, 2016
7f53cc3
Add failing tests for exhausted rate limit
divergentdave Jun 18, 2016
b30ae8a
Add status code and text to request error messages
divergentdave Jun 19, 2016
2a61ac4
Check created milestone ID before other tests
divergentdave Jun 19, 2016
9c63ebf
Fix ResponseError handling
divergentdave Jun 20, 2016
f3ff7fb
Improve successCallback error handling
divergentdave Jun 22, 2016
ae2fd3e
Add fixture data to replace live search API
divergentdave Jun 22, 2016
e483c35
Cleanup
divergentdave Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Cleanup
  • Loading branch information
@divergentdave
divergentdave committed Jun 22, 2016
commit e483c3512021007a69a7d220a3d84b92f0312292
3 changes: 1 addition & 2 deletions lib/Requestable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,7 @@ function callbackErrorOrThrow(cb, path) {
let error;
if (object.hasOwnProperty('config')) {
const {status, statusText, config: {method, url}} = object;
let message = (`${status} error making request ${method} ` +
`${url}: "${statusText}"`);
let message = (`${status} error making request ${method} ${url}: "${statusText}"`);
error = new ResponseError(message, path, object);
log(`${message} ${JSON.stringify(object.data)}`);
} else {
Expand Down