Skip to content

Create comment on issue function#209

Closed
randalmaia wants to merge 5 commits into
github-tools:masterfrom
randalmaia:master
Closed

Create comment on issue function#209
randalmaia wants to merge 5 commits into
github-tools:masterfrom
randalmaia:master

Conversation

@randalmaia
Copy link
Copy Markdown
Contributor

Create comment on issue function

thanks for this api.

@fdaciuk
Copy link
Copy Markdown

fdaciuk commented Aug 7, 2015

Nice feature :)

+1

@aendra-rininsland
Copy link
Copy Markdown
Member

Hi!
@randalmaia Thanks for the PR! Looks like a good feature and thanks ever-so-much for writing a test spec for the Issues API!

Could you please squash your commits? I'll then merge it thereafter. Thanks! 👍 :shipit:

@randalmaia
Copy link
Copy Markdown
Contributor Author

Why squash the commits @Aendrew ? I dont understand

@aendra-rininsland
Copy link
Copy Markdown
Member

@randalmaia Generally open source projects ask you to either rebase against master or squash your commits. This is to prevent a lot of iterative commits from filling up the project's commit history.

I've done so for you and merged to master. Thanks for your contribution! 👍 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants