fix(integrations): agy honors SPECKIT_INTEGRATION_AGY_EXTRA_ARGS#3347
Open
jawwad-ali wants to merge 1 commit into
Open
fix(integrations): agy honors SPECKIT_INTEGRATION_AGY_EXTRA_ARGS#3347jawwad-ali wants to merge 1 commit into
jawwad-ali wants to merge 1 commit into
Conversation
AgyIntegration.build_exec_args returned [exe, '--print', prompt] without calling _apply_extra_args_env_var(), so the documented per-integration extra-args env hook was silently dropped for agy — same class as the cursor-agent fix github#3265. Append the hook after the positional prompt, matching the devin integration's shape. agy still ignores model/output as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AgyIntegration.build_exec_argsreturned its argv in one line without calling_apply_extra_args_env_var():So
SPECKIT_INTEGRATION_AGY_EXTRA_ARGSwas silently dropped — the same class of bug fixed forcursor-agentin #3265. (argv[0] already went through_resolve_executable(), so the_EXECUTABLEoverride worked; only the extra-args hook was missing.)Fix
Append
self._apply_extra_args_env_var(args)after the positional prompt, matching thedevinintegration's shape ([exe, "-p", prompt]then hook). agy still ignoresmodel/output_jsonas before.Testing
Added to the existing
TestAgyBuildExecArgs:test_build_exec_args_honors_extra_args: with the env var set, argv ==['agy','--print','my prompt','--verbose']. Fails before (--verboseabsent — verified by source-stash), passes after;The 3 existing tests pin the env-unset shape and stay green.
uvx ruff checkclean.AI Disclosure
Found and fixed with Claude Code (Claude Fable 5) under my direction. AI flagged agy as another integration skipping the extra-args hook; I confirmed it, verified fail-before/pass-after, and reviewed the diff.