fix: skip JSONC merge to preserve user settings, fix docstring

- _merge_vscode_settings() now returns early (skips merge) when existing settings.json can't be parsed (e.g. JSONC with comments), instead of overwriting with empty settings - Updated _install_shared_infra() docstring to match implementation (scripts + templates, speckit.manifest.json)
github · mnriem · Mar 31, 2026 · Mar 31, 2026 · Mar 31, 2026 · Mar 31, 2026
commit f4ea768e4305d0f0ee10a932c7ee917a4d559422
@@ -1204,9 +1204,9 @@ def _install_shared_infra(
 ) -> bool:
     """Install shared infrastructure files into *project_path*.
 
-    Copies ``.specify/scripts/``, ``.specify/templates/``, and
-    ``.specify/memory/`` from the bundled core_pack or source checkout.
-    Tracks all installed files in ``_framework.manifest.json``.
+    Copies ``.specify/scripts/`` and ``.specify/templates/`` from the
+    bundled core_pack or source checkout.  Tracks all installed files
+    in ``speckit.manifest.json``.
     Returns ``True`` on success.
     """
     from .integrations.manifest import IntegrationManifest

@@ -141,11 +141,16 @@ def _merge_vscode_settings(src: Path, dst: Path) -> None:
 
         Top-level keys from *src* are added only if missing in *dst*.
         For dict-valued keys, sub-keys are merged the same way.
+
+        If *dst* cannot be parsed (e.g. JSONC with comments), the merge
+        is skipped to avoid overwriting user settings.
         """
         try:
             existing = json.loads(dst.read_text(encoding="utf-8"))
         except (json.JSONDecodeError, OSError):
-            existing = {}
+            # Cannot parse existing file (likely JSONC with comments).
+            # Skip merge to preserve the user's settings.
+            return
 
         new_settings = json.loads(src.read_text(encoding="utf-8"))