Skip to content

feat(scripts): add --dry-run flag to create-new-feature #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnriem merged 7 commits into from
Apr 2, 2026
Merged

feat(scripts): add --dry-run flag to create-new-feature #1998

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
42243ef
feat(scripts): add --dry-run flag to create-new-feature scripts
rhuss Mar 27, 2026
4378a1e
fix(scripts): gate specs/ dir creation behind dry-run check
rhuss Mar 27, 2026
ca4f930
fix: address PR review feedback
rhuss Mar 27, 2026
71e0b8f
fix: use git ls-remote for remote-aware dry-run numbering
rhuss Mar 28, 2026
8d4710d
fix(scripts): deduplicate number extraction and branch scanning logic
rhuss Mar 28, 2026
594f632
fix(tests): use isolated paths for remote branch test
rhuss Mar 28, 2026
4da0da6
fix: address PR review feedback
rhuss Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: address PR review feedback 
- Gate `mkdir -p $SPECS_DIR` behind DRY_RUN check (bash + PowerShell)
  so dry-run creates zero directories
- Add returncode assertion on `git branch --list` in test
- Strengthen spec dir test to verify root `specs/` is not created
- Add PowerShell dry-run test class (5 tests, skipped without pwsh)
- Fix run_ps_script to use temp repo copy instead of project root

Assisted-By: 🤖 Claude Code
  • Loading branch information
@rhuss
rhuss committed Mar 28, 2026
commit ca4f930158362eb841dbcbb340d2bbbfe1d4ef52
5 changes: 3 additions & 2 deletions tests/test_timestamp_branches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,9 @@ def _has_pwsh() -> bool:


def run_ps_script(cwd: Path, *args: str) -> subprocess.CompletedProcess:
"""Run create-new-feature.ps1 with given args."""
cmd = ["pwsh", "-NoProfile", "-File", str(CREATE_FEATURE_PS), *args]
"""Run create-new-feature.ps1 from the temp repo's scripts directory."""
script = cwd / "scripts" / "powershell" / "create-new-feature.ps1"
cmd = ["pwsh", "-NoProfile", "-File", str(script), *args]
return subprocess.run(cmd, cwd=cwd, capture_output=True, text=True)


Expand Down