Skip to content

fix(scripts): honor PowerShell agent and script filters #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnriem merged 1 commit into from
Mar 27, 2026
Merged

fix(scripts): honor PowerShell agent and script filters #1969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(scripts): honor PowerShell agent and script filters 
Rename the Normalize-List parameter in create-release-packages.ps1 to avoid conflicting with PowerShell's automatic $input variable. This fixes Windows offline scaffolding when -Agents and -Scripts are passed.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
  • Loading branch information
@chenry-me @sisyphus-dev-ai
chenry-me and sisyphus-dev-ai committed Mar 25, 2026
commit 35cc237996564814a14ffa82e1fcbe36e300380c
10 changes: 5 additions & 5 deletions .github/workflows/scripts/create-release-packages.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,13 +498,13 @@ $AllAgents = @('claude', 'gemini', 'copilot', 'cursor-agent', 'qwen', 'opencode'
$AllScripts = @('sh', 'ps')

function Normalize-List {
param([string]$Input)
param([string]$Value)

if ([string]::IsNullOrEmpty($Input)) {
if ([string]::IsNullOrEmpty($Value)) {
return @()
}

$items = $Input -split '[,\s]+' | Where-Object { $_ } | Select-Object -Unique
$items = $Value -split '[,\s]+' | Where-Object { $_ } | Select-Object -Unique
return $items
}

Expand All @@ -527,7 +527,7 @@ function Validate-Subset {

# Determine agent list
if (-not [string]::IsNullOrEmpty($Agents)) {
$AgentList = Normalize-List -Input $Agents
$AgentList = Normalize-List -Value $Agents
if (-not (Validate-Subset -Type 'agent' -Allowed $AllAgents -Items $AgentList)) {
exit 1
}
Expand All @@ -537,7 +537,7 @@ if (-not [string]::IsNullOrEmpty($Agents)) {

# Determine script list
if (-not [string]::IsNullOrEmpty($Scripts)) {
$ScriptList = Normalize-List -Input $Scripts
$ScriptList = Normalize-List -Value $Scripts
if (-not (Validate-Subset -Type 'script' -Allowed $AllScripts -Items $ScriptList)) {
exit 1
}
Expand Down
Loading