This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Repository navigation
Conversation
swinton
commented
Jun 25, 2018
|
|
||
| def send_messages(messages) | ||
| messages = Array(messages) | ||
| messages.push(*Service::DEPRECATION_NOTE.split("\n")) |
Contributor
Author
There was a problem hiding this comment.
It was necessary to split the DEPRECATION_NOTICE array up into separate lines, so the IRC command was correctly prepended to each line.
swinton
commented
Jun 25, 2018
|
|
||
| def send_messages(messages) | ||
| messages = Array(messages) | ||
| messages << Service::DEPRECATION_NOTE |
Contributor
Author
There was a problem hiding this comment.
🤔 I'm not sure if we should be similarly breaking this up into separate lines, or will XMPP accept multi-line text.
@gjtorikian any idea?
Contributor
There was a problem hiding this comment.
This issue suggests that multiple lines are fine. 🤷🏻♂️
jdennes
reviewed
Jul 26, 2018
| class Service | ||
| UTF8 = "UTF-8".freeze | ||
| DEPRECATION_NOTE = [ | ||
| "**NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/", |
Member
There was a problem hiding this comment.
Just noticed this pull request—it might be worth updating this to "This service has been marked for deprecation ...". See #1248.
|
Cidya iOS 12 |
zhouyoufu
approved these changes
Oct 22, 2018
russellgayo
approved these changes
Jan 8, 2019
rosid86
suggested changes
Jan 10, 2019
| default_events :push, :commit_comment, :issue_comment, | ||
| :issues, :pull_request, :pull_request_review_comment, | ||
| :gollum | ||
|
He |
|
email.rb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sends our deprecation notice with IRC and XMPP messages
To do