fix: let get_me handle missing arguments#2591
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
24cf9ff to
86ba852
Compare
Contributor
Author
|
Updated this branch onto current Validated locally: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2587.
The get_me tool has no inputs, but it still used the typed tool wrapper. That wrapper tries to unmarshal request arguments before the handler runs, so clients that omit the arguments field can fail even though the tool schema has no required fields.
This switches get_me to the raw handler wrapper and adds a regression test for a missing arguments field. Existing empty-object calls remain covered by the current successful get user case.
To verify: