Add formal RS-05a checkout gate coverage - #52103
Merged
pelikhan merged 2 commits intoAug 11, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add formal model and test suite for security architecture
Add formal RS-05a checkout gate coverage
Aug 11, 2026
pelikhan
marked this pull request as ready for review
August 11, 2026 17:20
Contributor
There was a problem hiding this comment.
Pull request overview
Adds dedicated formal test coverage for the existing RS-05a runtime PR checkout security gate.
Changes:
- Adds Node-bridged Go tests for repository, actor, parsing, ref, and PR-number validation.
- Verifies safe bypass and checkout behavior.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/security_architecture_rs05a_formal_test.go |
Adds comprehensive RS-05a runtime checkout tests and helpers. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
PR Triage: #52103
Automated triage — see labels for machine-readable classification.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RS-05arequiresworkflow_dispatchruns withaw_context.item_type == "pull_request"to gate PR checkout on repository scope, actor trust, parse resilience, ref isolation, and a valid PR number. Existing SG formal tests covered SG-01..SG-07 but did not dedicatedly formalize this runtime checkout path.Formal RS-05a test suite
pkg/workflow/security_architecture_rs05a_formal_test.go.item_number, and non-PR bypass.Runtime behavior asserted
aw_context.reposkips checkout with a warning.git fetch origin +refs/pull/<N>/head:....