Extend MCP logs timeout for engine-filtered queries by Copilot · Pull Request #52063 · github/gh-aw

Copilot · 2026-08-11T13:22:50Z

Engine-filtered logs requests can scan workflow artifacts across runs and exceed the default one-minute budget, even for small result counts. The compile tool also did not show that workflows accepts an array.

Logs timeout
- Apply the existing five-minute implicit timeout floor when engine is specified.
- Preserve explicit timeout values and count-based scaling.

if workflowName == "" || engine != "" {
    return max(defaultMCPLogsMinTimeoutMinutesAllWorkflows, base)
}

Regression coverage
- Cover engine-filtered requests with a named workflow.
Compile tool schema
- Document array input syntax: ["workflow.md"].

Fixes [cli-tools-test] logs tool: engine filter query exceeds default timeout (context deadline exceeded) #51952

Run: https://github.com/github/gh-aw/actions/runs/31508439729> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 35.1 AIC · ⌖ 6.14 AIC · ⊞ 8.5K · ◷

_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.5 AIC · ⌖ 3.4 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Extends MCP log-query timeouts for engine-filtered requests and clarifies compile workflow input syntax.

Changes:

Applies the five-minute timeout floor to engine filters.
Adds timeout and schema regression coverage.
Documents array syntax for compile inputs.

Show a summary per file

File	Description
`pkg/cli/mcp_tools_readonly.go`	Clarifies compile workflow array syntax.
`pkg/cli/mcp_tools_privileged.go`	Extends engine-filtered log timeouts.
`pkg/cli/mcp_tools_privileged_test.go`	Updates timeout helper invocation.
`pkg/cli/mcp_server_defaults_test.go`	Tests compile schema documentation.
`pkg/cli/logs_timeout_test.go`	Tests engine-filtered timeout behavior.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 5/5 changed files
Comments generated: 1
Review effort level: Balanced

Copilot · 2026-08-11T16:01:39Z

+	if workflowName == "" || engine != "" {
+		// Without a workflow filter, or when filtering by engine, the CLI scans runs
+		// across workflows and reads their artifacts. Apply a higher minimum so the
+		// tool is less likely to exhaust the MCP gateway's per-tool timeout.
 		return max(defaultMCPLogsMinTimeoutMinutesAllWorkflows, base)


Fixed in the latest commit — getToolCallTimeoutMs now applies the 5-minute floor whenever engine is present, even if workflow_name is also set. Added bridge regression tests for both cases.

github-actions · 2026-08-11T14:05:13Z

✅ Test Quality Sentinel completed test quality analysis.

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-11T14:05:14Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #52063

github-actions · 2026-08-11T14:05:20Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #52063 does not have the implementation label and has only 35 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-11T14:05:21Z

✅ PR Code Quality Reviewer completed the code quality review.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

api.individual.githubcopilot.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.individual.githubcopilot.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-11T14:05:23Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions

The changes look correct and well-tested. The engine parameter addition to effectiveMCPLogsToolTimeoutMinutes is sound — engine-filtered queries scan across workflows just like no-workflow-name queries, so applying the higher timeout floor is the right behavior. All call sites and tests are updated consistently.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 13.9 AIC · ⌖ 6.13 AIC · ⊞ 5.4K

github-actions · 2026-08-11T14:11:23Z

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 100/100 — Excellent

Analyzed 3 test change(s): 3 design, 0 implementation, 0 violation(s).

📊 Metrics (3 tests)

Metric	Value
Analyzed	3 (Go: 3, JS: 0)
✅ Design	3 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	3 (100%)
Duplicate clusters	0
Inflation	No
🚨 Violations	0

Test	File	Classification	Issues
`TestEffectiveMCPLogsToolTimeoutMinutes` (engine rows + cap rows)	`logs_timeout_test.go`	`design_test` / `high_value`	None
`TestMCPToolElicitationDefaults` (new subtest: no timeout schema default)	`mcp_server_defaults_test.go`	`design_test` / `high_value`	None
`TestLogsToolUsesEffectiveCountForTimeoutScaling` (subtest update)	`mcp_tools_privileged_test.go`	`design_test` / `high_value`	None

Analysis

This PR extends effectiveMCPLogsToolTimeoutMinutes to apply an all-workflow minimum timeout floor when an engine filter is supplied (in addition to when workflow_name is absent). The test additions are well-matched to the behavioral contracts:

Engine-filter rows (engine: "claude", count=2, named workflow) verify that a non-empty engine triggers the all-workflow floor — covering the new code path directly. Boundary rows (explicit timeout preserved, count-based scaling, max cap) ensure regression protection for adjacent paths.
No static timeout schema default subtest (mcp_server_defaults_test.go) is a crisp design invariant: it asserts absence of a value rather than presence, protecting against future accidental re-introduction of a static default that would bypass the runtime computation.
Effective count / timeout scaling integration subtest (mcp_tools_privileged_test.go) validates the end-to-end wire-up: the subprocess actually receives the computed --timeout value.

All test files carry (go/redacted):build !integration build tags ✅. No Go mock libraries (gomock, testify/mock) used. No inflation (net test additions ≤ net production additions). No duplicate clusters.

Verdict

✅ Passed. 0% implementation tests (threshold: 30%). No violations.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 · 36.9 AIC · ⌖ 6.82 AIC · ⊞ 7.6K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 100/100. 0% implementation tests (threshold: 30%).

github-actions

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 27.7 AIC · ⌖ 6.5 AIC · ⊞ 7.1K
_{Comment /matt to run again}

github-actions · 2026-08-11T14:15:37Z

 		},
 		// All-workflow cases: minimum 5 minutes when no workflow_name is given
+		{
+			name:             "engine filtering uses all-workflow minimum for a named workflow",


[/tdd] The new test case sits under the // All-workflow cases comment but tests a named workflow with engine filtering — a mismatch that could mislead future editors. There is also no test for the workflowName="" + engine!="" combination, leaving one branch of the || uncovered.

💡 Suggested additions

Move the case to a new section and add a companion:

// Engine-filtering cases { name: "engine filtering with named workflow uses all-workflow minimum", requestedTimeout: 0, count: 2, workflowName: "my-workflow", engine: "claude", want: defaultMCPLogsMinTimeoutMinutesAllWorkflows, }, { name: "engine filtering without workflow name also uses all-workflow minimum", requestedTimeout: 0, count: 2, workflowName: "", engine: "claude", want: defaultMCPLogsMinTimeoutMinutesAllWorkflows, },

@copilot please address this.

Moved the engine-filtering case into its own "Engine-filtering cases" section and added the missing workflowName="" + engine!="" companion test.

…meout-fix

gh-aw-bot · 2026-08-11T15:50:54Z

@copilot Please refresh this branch, verify checks, and use the pr-finisher skill before handing back.

No failed checks were reported in the compact candidate set for this run.
Branch update was requested by sous-chef in run https://github.com/github/gh-aw/actions/runs/31508439729.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 35.1 AIC · ⌖ 6.14 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

github-actions · 2026-08-11T18:37:11Z

PR Triage: #52063

Category: bug
Risk: low
Priority score: 53/100 (impact 20/50, urgency 18/30, quality 15/20) → medium
Recommended action: fast_track

Automated triage — see labels for machine-readable classification.

Generated by 🔧 PR Triage Agent · auto · 45 AIC · ⌖ 2.09 AIC · ⊞ 7.8K · ◷

…meout-fix

gh-aw-bot · 2026-08-11T18:47:00Z

@copilot Please refresh this branch, verify checks, and use the pr-finisher skill before handing back.

No failed checks were reported in the compact candidate set for this run.
Branch update was requested by sous-chef in run https://github.com/github/gh-aw/actions/runs/31523880210.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.5 AIC · ⌖ 3.4 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Initial plan

010ce52

Copilot AI assigned Copilot and pelikhan Aug 11, 2026

Copilot started work on behalf of pelikhan August 11, 2026 13:24 View session

Copilot AI linked an issue Aug 11, 2026 that may be closed by this pull request

[cli-tools-test] logs tool: engine filter query exceeds default timeout (context deadline exceeded) #51952

Closed

Copilot AI and others added 2 commits August 11, 2026 13:34

Extend logs timeout for engine filters

c374b86

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Document compile workflows array input

fc7d7a9

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix engine filter timeout in logs tool~~ Extend MCP logs timeout for engine-filtered queries Aug 11, 2026

Copilot AI requested a review from pelikhan August 11, 2026 13:37

Copilot finished work on behalf of pelikhan August 11, 2026 13:37

pelikhan marked this pull request as ready for review August 11, 2026 13:43

Copilot AI balanced review requested due to automatic review settings August 11, 2026 13:43

Copilot started reviewing on behalf of pelikhan August 11, 2026 13:44 View session

Copilot AI reviewed Aug 11, 2026

View reviewed changes

github-actions Bot approved these changes Aug 11, 2026

View reviewed changes

This was referenced Aug 11, 2026

[aw] No-Op Runs #48838

Open

[aw] PR Code Quality Reviewer produced no safe outputs #52066

Closed

github-actions Bot added the needs-review label Aug 11, 2026

github-actions Bot reviewed Aug 11, 2026

View reviewed changes

Merge branch 'main' into copilot/cli-tools-test-logs-engine-filter-ti…

d54ce44

…meout-fix

github-actions Bot mentioned this pull request Aug 11, 2026

[pr-sous-chef] PR Sous Chef run report - 2026-08-11T01:46Z #51906

Closed

Copilot started work on behalf of gh-aw-bot August 11, 2026 15:51 View session

Apply 5-minute timeout floor to bridge when engine filter is present

ebf29a3

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 11, 2026 16:02

Copilot AI requested a review from gh-aw-bot August 11, 2026 16:02

github-actions Bot added pr-action:fast_track pr-agent:copilot pr-priority:medium pr-risk:low pr-type:bug labels Aug 11, 2026

github-actions Bot mentioned this pull request Aug 11, 2026

[PR Triage Report] PR Triage Report — 2026-08-11 (Run 31522790297) #52130

Closed

Merge branch 'main' into copilot/cli-tools-test-logs-engine-filter-ti…

806377f

…meout-fix

Copilot started work on behalf of gh-aw-bot August 11, 2026 18:47 View session

Copilot finished work on behalf of gh-aw-bot August 11, 2026 18:53

pelikhan merged commit 7700358 into main Aug 11, 2026
1 check passed

pelikhan deleted the copilot/cli-tools-test-logs-engine-filter-timeout-fix branch August 11, 2026 22:34

Uh oh!

Conversation

Copilot AI commented Aug 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Copilot AI Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 11, 2026

🧪 Test Quality Sentinel Report

Analysis

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

PR Triage: #52063

Uh oh!

gh-aw-bot commented Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 11, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading