Refactor duplicated reaction setup into shared helper by Copilot · Pull Request #43483 · github/gh-aw

Copilot · 2026-07-05T06:33:56Z

The reaction-only and reaction-plus-comment action scripts duplicated the same setup path (read GH_AW_REACTION, validate allowed reactions, resolve invocation context), creating drift risk between entrypoints. This change consolidates that setup into one helper and keeps each entrypoint focused on its distinct side effects.

Problem summary
- Both add_reaction.cjs and add_reaction_and_edit_comment.cjs implemented identical reaction initialization/validation/context-resolution logic.
- Duplication increased maintenance risk when reaction rules or invocation-context behavior change.
Refactor: shared reaction setup
- Added actions/setup/js/reaction_setup_helpers.cjs:
  - exports VALID_REACTIONS
  - exports resolveReactionSetup(context) returning { reaction, invocationContext } or null after core.setFailed(...)
- Centralizes:
  - default reaction fallback (eyes)
  - reaction allowlist validation
  - invocation context resolution
Entrypoint updates
- actions/setup/js/add_reaction.cjs
  - replaced inline setup/validation/context code with resolveReactionSetup(context).
- actions/setup/js/add_reaction_and_edit_comment.cjs
  - removed duplicated setup block and VALID_REACTIONS constant
  - now imports shared setup + allowlist from reaction_setup_helpers.cjs.
Targeted coverage
- Added actions/setup/js/reaction_setup_helpers.test.cjs to cover:
  - default reaction behavior
  - environment override behavior
  - invalid reaction failure path

// shared setup used by both entrypoints
const setup = resolveReactionSetup(context);
if (!setup) return;

const { reaction, invocationContext } = setup;

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…ispatch

Copilot

Pull request overview

This PR refactors duplicated reaction initialization/validation and invocation-context resolution logic used by the setup action scripts into a shared helper, reducing drift risk between the reaction entrypoints.

Changes:

Added a new reaction_setup_helpers.cjs module that centralizes the reaction allowlist and the “reaction + invocation context” setup logic.
Updated both reaction entrypoints (add_reaction.cjs and add_reaction_and_edit_comment.cjs) to use the shared setup helper instead of duplicating setup/validation logic.
Added targeted unit tests for the new helper covering default reaction, env override, and invalid reaction handling.

Show a summary per file

File	Description
actions/setup/js/reaction_setup_helpers.cjs	Introduces shared reaction setup/validation + invocation-context resolution helper.
actions/setup/js/add_reaction.cjs	Refactors reaction-only entrypoint to use the shared setup helper.
actions/setup/js/add_reaction_and_edit_comment.cjs	Refactors reaction+comment entrypoint to use the shared setup helper and import the shared allowlist.
actions/setup/js/reaction_setup_helpers.test.cjs	Adds unit coverage for shared helper behavior (default, override, invalid).

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 4/4 changed files
Comments generated: 2
Review effort level: Low

+function resolveReactionSetup(rawContext) {
+  const reaction = process.env.GH_AW_REACTION || "eyes";
+  const invocationContext = resolveInvocationContext(rawContext);
+  if (!VALID_REACTIONS.includes(reaction)) {
+    core.setFailed(`${ERR_VALIDATION}: Invalid reaction type: ${reaction}. Valid reactions are: ${VALID_REACTIONS.join(", ")}`);
+    return null;
+  }
+  return { reaction, invocationContext };
+}


+  it("fails and returns null for invalid reaction", async () => {
+    process.env.GH_AW_REACTION = "invalid";
+    const { resolveReactionSetup } = await importHelpers();
+
+    const result = resolveReactionSetup({
+      eventName: "issues",
+      repo: { owner: "testowner", repo: "testrepo" },
+      payload: { issue: { number: 123 } },
+    });
+
+    expect(result).toBeNull();
+    expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringContaining("Invalid reaction type: invalid"));
+  });
+});


pelikhan · 2026-07-05T07:00:33Z

@copilot invoke pr-finisher skill

gh-aw-bot · 2026-07-05T07:04:16Z

@copilot please run the pr-finisher skill, review the existing PR feedback, make any needed follow-up changes, and rerun checks if code changes are required.

Generated by 👨‍🍳 PR Sous Chef · 12.3 AIC · ⌖ 5.1 AIC · ⊞ 3.5K · ◷
_{Comment /souschef to run again}

…ION_MAP sync test Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-05T07:25:23Z

@copilot invoke pr-finisher skill

Addressed both reviewer threads in commit fix: validate reaction before resolving invocation context; add REACTION_MAP sync test:

Order fix (reaction_setup_helpers.cjs): moved reaction validation before resolveInvocationContext so an invalid GH_AW_REACTION produces core.setFailed(...) rather than a potential uncaught exception from context parsing.
Sync test (reaction_setup_helpers.test.cjs): added a test that imports REACTION_MAP from add_reaction.cjs and asserts [...VALID_REACTIONS].sort() equals Object.keys(REACTION_MAP).sort(), catching any future drift between the two.

All 4 unit tests pass locally.

github-actions · 2026-07-05T07:27:34Z

🤖 PR Triage — Run #7

Field	Value
Category	refactor
Risk	🟢 low
Score	40 / 100
Action	📋 `batch_review`
Batch	`pr-batch:js-refactor`

Score breakdown: impact 16 + urgency 12 + quality 12

Extracts shared resolveReactionSetup helper from add_reaction.cjs and add_reaction_and_edit_comment.cjs. Adds targeted test coverage. 4 files, +97/-22. Review alongside #43480 as part of the JS refactor batch.

Generated by 🔧 PR Triage Agent · 56.3 AIC · ⌖ 8.84 AIC · ⊞ 5.5K · ◷

Initial plan

70a6ec5

Copilot AI assigned Copilot and pelikhan Jul 5, 2026

Copilot started work on behalf of pelikhan July 5, 2026 06:34 View session

Copilot AI linked an issue Jul 5, 2026 that may be closed by this pull request

[duplicate-code] Duplicate Code: Reaction Validation and Dispatch #43481

Open

Copilot AI and others added 2 commits July 5, 2026 06:43

refactor: share reaction setup validation logic

bd2a559

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

style: fix jsdoc spacing in reaction setup helper

3d0b967

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor duplicate reaction validation and dispatch code~~ Refactor duplicated reaction setup into shared helper Jul 5, 2026

Copilot AI requested a review from pelikhan July 5, 2026 06:46

Copilot finished work on behalf of pelikhan July 5, 2026 06:46

pelikhan marked this pull request as ready for review July 5, 2026 06:47

Copilot AI review requested due to automatic review settings July 5, 2026 06:47

Merge branch 'main' into copilot/duplicate-code-reaction-validation-d…

aeae25c

…ispatch

Copilot started reviewing on behalf of pelikhan July 5, 2026 06:47 View session

Copilot AI reviewed Jul 5, 2026

View reviewed changes

Copilot started work on behalf of pelikhan July 5, 2026 07:18 View session

fix: validate reaction before resolving invocation context; add REACT…

5017107

…ION_MAP sync test Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 5, 2026 07:25

Copilot started work on behalf of gh-aw-bot July 5, 2026 07:25 View session

github-actions Bot added pr-action:batch_review pr-agent:copilot-swe-agent pr-batch:js-refactor pr-priority:medium pr-risk:low pr-type:refactor labels Jul 5, 2026

github-actions Bot mentioned this pull request Jul 5, 2026

Deduplicate skip-query gate logic for setup action guards #43480

Open

github-actions Bot mentioned this pull request Jul 5, 2026

[PR Triage Report] PR Triage Report — Run #7 (2026-07-05) #43502

Open

Copilot finished work on behalf of gh-aw-bot July 5, 2026 07:36

Copilot AI requested a review from gh-aw-bot July 5, 2026 07:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor duplicated reaction setup into shared helper#43483

Refactor duplicated reaction setup into shared helper#43483
pelikhan with Copilot wants to merge 5 commits into
mainfrom
copilot/duplicate-code-reaction-validation-dispatch

Copilot AI commented Jul 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

pelikhan commented Jul 5, 2026

Uh oh!

gh-aw-bot commented Jul 5, 2026

Uh oh!

Copilot AI commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

pelikhan commented Jul 5, 2026

Uh oh!

gh-aw-bot commented Jul 5, 2026

Uh oh!

Copilot AI commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

🤖 PR Triage — Run #7

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 5, 2026 •

edited

Loading