[review] fix(arc-dind): mount workspace correctly and unify artifact roots#43228
Open
github-actions[bot] wants to merge 5 commits into
Open
[review] fix(arc-dind): mount workspace correctly and unify artifact roots#43228github-actions[bot] wants to merge 5 commits into
github-actions[bot] wants to merge 5 commits into
Conversation
Bug A: The agent sees an empty workspace because dockerHostPathPrefix
translates the workspace mount source to a non-existent path. With
sysroot-stage active, the Docker daemon can see all needed paths via:
- Shared work volume (/home/runner/_work/) for workspace & RUNNER_TEMP
- Sysroot named volume for system binaries
- Kernel VFS for /dev, /sys
Remove dockerHostPathPrefix from the AWF config — it's unnecessary and
harmful when sysroot provides all system paths.
Bug B: The agent artifact upload spans two path roots (/tmp/gh-aw/ and
${{ runner.temp }}/gh-aw/), causing upload-artifact to compute '/' as
the common ancestor. This creates a nested directory layout that breaks
downstream artifact downloads (detection job can't find agent_output.json).
Fix by:
1. Rewriting all /tmp/gh-aw/ artifact paths to ${{ runner.temp }}/gh-aw/
2. Adding a consolidation step that copies /tmp/gh-aw/ contents to the
runner.temp location before upload
Fixes: gh-aw#34896
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
@copilot please run the
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Contributor
Done. Found one lint failure (
Hand-off: CI must be re-triggered by a maintainer (close/reopen PR, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.
Reason: agent_failure
Review the workflow run logs for details.
This PR contains changes that were originally intended for PR #43222 (
fix/arc-dind-workspace-mount).Please review the changes carefully before merging.