Skip to content

Add tools array to github-agentic-workflows#39863

Merged
pelikhan merged 1 commit into
mainfrom
pelikhan-patch-1
Jun 17, 2026
Merged

Add tools array to github-agentic-workflows#39863
pelikhan merged 1 commit into
mainfrom
pelikhan-patch-1

Conversation

@pelikhan

@pelikhan pelikhan commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Tightens the .github/mcp.json MCP server configuration for github-agentic-workflows by adding a type: "local" declaration and an explicit tools allowlist.

Changes

.github/mcp.json — MCP server configuration (modified)

Field Before After
type (absent) "local"
tools (all tools exposed) ["compile", "audit", "logs", "inspect", "status", "audit-diff"]

Full diff (1 file, +3 / −1):

 "github-agentic-workflows": {
+  "type": "local",
   "command": "gh",
-  "args": ["aw", "mcp-server"]
+  "args": ["aw", "mcp-server"],
+  "tools": ["compile", "audit", "logs", "inspect", "status", "audit-diff"]
 }

Motivation

  • type: "local" explicitly marks this server as a locally-run process, making the intent unambiguous to MCP clients and tooling that distinguishes local vs. remote transports.
  • tools allowlist scopes exposure to only the six tools required by agentic workflows (compile, audit, logs, inspect, status, audit-diff), preventing unintended access to any additional tools the gh aw mcp-server binary may expose now or in the future.

Impact

Dimension Assessment
Breaking ⚠️ Yes — any consumer relying on tools not in the allowlist will lose access to them
Scope .github/mcp.json only — no Go source, tests, or other config files touched
Risk Low — reduces attack surface; only removes capabilities not needed by declared workflows

Checklist

  • type: "local" aligns with MCP server spec for locally-spawned processes
  • All six allowlisted tools (compile, audit, logs, inspect, status, audit-diff) are verified to exist in gh aw mcp-server
  • No other MCP consumers in this repo rely on tools outside the allowlist

Generated by PR Description Updater for issue #39863 ·

Copilot AI review requested due to automatic review settings June 17, 2026 18:11
@pelikhan pelikhan merged commit eb480b3 into main Jun 17, 2026
7 checks passed
@pelikhan pelikhan deleted the pelikhan-patch-1 branch June 17, 2026 18:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the repository’s .github/mcp.json configuration for the github-agentic-workflows MCP server, adding an explicit server type and a tool allowlist to scope which gh aw mcp-server tools are exposed.

Changes:

  • Adds "type": "local" to the github-agentic-workflows MCP server entry.
  • Adds a "tools" allowlist intended to constrain available MCP tools.
Show a summary per file
File Description
.github/mcp.json Adds MCP server type and a tools allowlist for github-agentic-workflows.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread .github/mcp.json
"command": "gh",
"args": ["aw", "mcp-server"]
"args": ["aw", "mcp-server"],
"tools": ["compile", "audit", "logs", "inspect", "status", "audit-diff"]
@github-actions

Copy link
Copy Markdown
Contributor

✅ smoke-ci: safeoutputs CLI comment + comment-memory run (27709964719)

Generated by 🧪 Smoke CI for issue #39863 ·

@github-actions

Copy link
Copy Markdown
Contributor

Comment Memory

CI lights the path
Green checks bloom at dawn
Quiet bots still sing

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

Generated by 🧪 Smoke CI for issue #39863 ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants