Skip to content

chore: expand pr to issue tracing for impact report mapped outcomes#39620

Merged
mnkiefer merged 7 commits into
mainfrom
copilot/fix-mapped-outcomes-in-report
Jun 16, 2026
Merged

chore: expand pr to issue tracing for impact report mapped outcomes#39620
mnkiefer merged 7 commits into
mainfrom
copilot/fix-mapped-outcomes-in-report

Conversation

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Impact Efficiency Report was undercounting accepted mapped outcomes because PR root-issue tracing only captured a subset of closing references and operated on a small PR sample. This change broadens linkage extraction and increases dataset coverage so mapped outcome counts reflect actual traced work.

  • Root cause

    • Linked issue detection relied primarily on Closes/Fixes/Resolves #N body parsing, missing canonical PR closing references.
    • PR collection limit (500) truncated the analysis window in active repos.

  • Changes

    • Added closingIssuesReferences to both merged and closed-unmerged PR dataset queries.
    • Updated linked-issue derivation to merge:
      • GraphQL closing references (closingIssuesReferences)
      • Existing body-regex matches (fallback)
    • Deduplicated merged link sets before writing linked_issue_numbers.
    • Replaced hardcoded PR limit with OBJECTIVE_IMPACT_PR_LIST_LIMIT (default 5000) for broader, configurable coverage.

  • Behavioral impact

    • More PR outcomes now resolve to traced root issues.
    • Accepted mapped outcome counts in the impact report are expected to increase from the previous undercount.
# Before (narrow + fixed cap)
gh pr list ... --limit 500 --json number,title,url,mergedAt,closedAt,body,labels

# After (broader tracing + configurable cap)
gh pr list ... --limit "$pr_list_limit" \
  --json number,title,url,mergedAt,closedAt,body,labels,closingIssuesReferences

Copilot AI and others added 2 commits June 16, 2026 17:29
@mnkiefer
Plan: fix objective impact linked issue tracing
235830a 
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer
Fix linked issue tracing for objective impact report
f2cafe0 
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer mnkiefer marked this pull request as ready for review June 16, 2026 17:34
Copilot AI review requested due to automatic review settings June 16, 2026 17:34
@mnkiefer mnkiefer changed the title Expand PR→issue tracing for impact report mapped outcomes Expand pr to issue tracing for impact report mapped outcomes Jun 16, 2026
@mnkiefer mnkiefer changed the title Expand pr to issue tracing for impact report mapped outcomes chore: expand pr to issue tracing for impact report mapped outcomes Jun 16, 2026
@mnkiefer

mnkiefer commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@copilot Recompile workflows

Copilot AI reviewed Jun 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The updated workflows/scripts introduce avoidable failure and injection risks (unvalidated limit input and unsafe $GITHUB_OUTPUT writes) that should be addressed before approval.

Pull request overview

This pull request improves the Objective Impact Efficiency Report dataset generation so PR→issue tracing captures GitHub-native closing references and covers a wider PR sample window, reducing undercounting of mapped outcomes.

Changes:

  • Increased PR dataset coverage by making the PR list limit configurable via OBJECTIVE_IMPACT_PR_LIST_LIMIT (default 5000).
  • Expanded linked-issue derivation to merge closingIssuesReferences (GraphQL/gh pr list --json) with existing body regex detection, with deduplication.
  • Updated compiled workflow/runtime plumbing (Objective Impact lock workflow) and hardened output recording in agentics-maintenance.yml.
File summaries
File Description
scripts/prepare-objective-impact-report-dataset.sh Expands PR→issue linkage extraction and increases PR sampling via a configurable limit.
.github/workflows/objective-impact-report.lock.yml Updates compiled workflow steps for MCP/safe-outputs startup configuration.
.github/workflows/agentics-maintenance.yml Adjusts how workflow inputs are written to $GITHUB_OUTPUT via env indirection.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 4

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/prepare-objective-impact-report-dataset.sh
Comment thread .github/workflows/agentics-maintenance.yml
Comment thread .github/workflows/agentics-maintenance.yml
Comment thread .github/workflows/objective-impact-report.lock.yml

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Recompile workflows

Ran make recompile — all 249 workflows compiled successfully (0 errors). The .lock.yml files were already in sync with the workflow sources, so no new changes were produced.

Copilot AI requested a review from mnkiefer June 16, 2026 17:45
mnkiefer and others added 2 commits June 16, 2026 19:46
@mnkiefer
Potential fix for pull request finding
2986c43 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mnkiefer
Potential fix for pull request finding
0bd6d1e 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mnkiefer

mnkiefer commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@copilot Revert changes to .github/workflows/agentics-maintenance.yml. You are only allowed to make fixes/changes to objective-impact-report.md and it's prepare script.

@mnkiefer
revert: undo changes to agentics-maintenance.yml
43b161b 
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Revert changes to [.github/workflows/agentics-maintenance.yml. You are only allowed to make fixes/changes to objective-impact-report.md and it's prepare script.

Reverted in 43b161b — .github/workflows/agentics-maintenance.yml is restored to its pre-PR state.

@mnkiefer

mnkiefer commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@copilot Recompile workflow

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Recompile workflow

Ran make recompile — all 249 workflows compiled successfully (0 errors). The .lock.yml files are already in sync with the current sources.

@mnkiefer

mnkiefer commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@copilot Recompile workflow and check tests

@mnkiefer
chore: recompile workflows (mcpg v0.3.25 → v0.3.26)
1e65fe5 
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Recompile workflow and check tests

Recompiled in the latest commit — 249 workflows compiled (0 errors), lock files updated (mcpg bumped to v0.3.26). All tests pass.

@github-actions github-actions Bot mentioned this pull request Jun 16, 2026
Closed
@mnkiefer mnkiefer merged commit c2cc098 into main Jun 16, 2026
@mnkiefer mnkiefer deleted the copilot/fix-mapped-outcomes-in-report branch June 16, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mnkiefer mnkiefer Awaiting requested review from mnkiefer

Assignees

@mnkiefer mnkiefer

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnkiefer