Repository navigation
Fix .NET caching prerequisites and test artifact workflow - #46336
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
@4booser is this PR in fact still in Draft? |
now it's ready to review |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Two examples in "Building and testing .NET" can prevent readers from running the documented workflows:
stepsunderstrategy, which is not a valid GitHub Actions job structure.cache: truewithout explaining that a committed NuGet lock file must already be available.setup-dotnetfails when it cannot find a matching lock file.What's being changed (if available, include any code snippets, screenshots, or gifs):
always()upload condition.packages.lock.jsonbefore enabling caching.cache-dependency-path: '**/packages.lock.json'for lock files in subdirectories or multiple projects.dotnet restore --locked-modeinstead of adding a dependency during the cached workflow.References:
Validation:
Local checks passed against upstream commit
0226a2d78cf2be40ee3d769ec5661638461af0cc; the original article is unchanged at this branch's base:node --import tsx src/content-linter/scripts/lint-content.ts --paths content/actions/tutorials/build-and-test-code/net.md.npm run build.CHANGED_FILES=content/actions/tutorials/build-and-test-code/net.md npm run test -- src/content-render/tests/render-changed-and-deleted-files.ts --run(2 tests).git diff --check.The workflows have not been executed on a GitHub-hosted runner. The render test exited successfully with a server-shutdown warning.
Check off the following: