Skip to content

Update generating-a-json-web-token-jwt-for-a-github-app.md#30450

Merged
skedwards88 merged 1 commit into
github:mainfrom
mark-mxwl:patch-4
Dec 11, 2023
Merged

Update generating-a-json-web-token-jwt-for-a-github-app.md#30450
skedwards88 merged 1 commit into
github:mainfrom
mark-mxwl:patch-4

Conversation

@mark-mxwl

Copy link
Copy Markdown
Contributor

Why:

Closes: #30360

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updated the module import statement for the Python JWT script, as proposed in the issue's comments.

from jwt import JWT, jwk_from_pem
signing_key = jwk_from_pem(pem_file.read())
jwt_instance = JWT()

The updated script has been tested locally and works as expected.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Updated module import statement for the Python JWT script, as proposed in the issue's comments.
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Dec 8, 2023
@github-actions

github-actions Bot commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@skedwards88 skedwards88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! Thanks also for answering the contributor question over in #30360 (comment) 💖 We'll get this merged for you.

@skedwards88 skedwards88 added this pull request to the merge queue Dec 11, 2023
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Dec 11, 2023
Merged via the queue into github:main with commit b7d07f9 Dec 11, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@mark-mxwl

Copy link
Copy Markdown
Contributor Author

My pleasure, and thx so much! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This pull request is ready to merge triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docs for Generating a JWT for GitHub App

3 participants