Skip to content

Update windows_git_for_windows_turn_on_ssh_agent.md#29717

Closed
igorjcl wants to merge 6 commits into
github:mainfrom
igorjcl:patch-2
Closed

Update windows_git_for_windows_turn_on_ssh_agent.md#29717
igorjcl wants to merge 6 commits into
github:mainfrom
igorjcl:patch-2

Conversation

@igorjcl

@igorjcl igorjcl commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

Why: Shell code formatting is incorrect

Closes: #29644

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome

welcome Bot commented Nov 3, 2023

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 3, 2023
subatoi
subatoi previously approved these changes Nov 3, 2023

@subatoi subatoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is the correct fix: I actually had a PR open internally but I'm very happy to accept this one instead :)

Comment thread data/reusables/desktop/windows_git_for_windows_turn_on_ssh_agent.md Outdated
@subatoi

subatoi commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

Apologies! My suggestion to fix the indentation managed to remove the terminating backticks, and I don't have permission to push to the branch to rectify it. I'm happy to approve this PR when the build succeeds: as far as I can tell, the reason for the failure is probably transient. If adding the backticks and updating the branch doesn't fix the build, I'll follow up with the engineering team internally.

Thanks again for raising this and sorry for the confusion: do please let me know if you'd prefer me to get this change merged internally and I'm happy to add you as co-committer 😄

@igorjcl

igorjcl commented Nov 3, 2023

Copy link
Copy Markdown
Contributor Author

@subatoi, thank you for your attention. I prefer the change to be made internally. Please proceed with the necessary alterations, and I would appreciate it if you could add me as a co-author.

@subatoi

subatoi commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

No problem @igorjcl — thanks for your patience!

I've just committed a fix for this. You should no longer see the issue you reported on https://docs.github.com/pt/authentication/troubleshooting-ssh/error-permission-denied-publickey#make-sure-you-have-a-key-that-is-being-used. You may need to open an incognito browser or send a junk query string to see it on the live page, if you don't see it straightaway.

When the next repo-sync runs, you should see yourself as co-committer. If you're happy with all this, we can close this issue out!

@subatoi

subatoi commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Just to add: this is the commit I was referring to c512459

I can see the changes haven't propagated yet to the Portuguese language version. I'll check back with this tomorrow but I can see the example is fixed on the English language version.

@igorjcl igorjcl closed this Nov 7, 2023
@subatoi

subatoi commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

Just to let you know I've followed up internally: the Portuguese version should see the updates soon. I'll check back next week!

@igorjcl

igorjcl commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @subatoi

@subatoi

subatoi commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Hi @igorjcl I just wanted to follow up again: the fix has been shipped to the non-English docs now (including Portuguese). Thanks again for raising this and apologies that it took so long to appear there!

@myarb myarb removed the triage Do not begin working on this issue until triaged by the team label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell code formatting is incorrect

3 participants