Remove obsolete workflow_dispatch trigger from "cleanup caches" example#23650
Conversation
Following up on PR github#26312, which changed `BRANCH` from `github.ref` into a reference only valid for pull requests. Thus, I believe this workflow cannot be reasonably run by manual dispatch anymore.
workflow_dispatch trigger from "cleanup caches"exampleworkflow_dispatch trigger from "cleanup caches" example
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
@andreasabel Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
SiaraMist
left a comment
There was a problem hiding this comment.
Hey @andreasabel, thank you for catching this! Your update makes sense to me. I'll go ahead and get this merged. 🚀
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Following up on PR #23612, which changed
BRANCHfromgithub.refinto a reference only valid for pull requests.I believe this workflow cannot be reasonably run by manual dispatch anymore. Thus the
workflow_dispatchtrigger should be removed to avoid confusion.References: