Skip to content

Update workflow-commands-for-github-actions.md#216

Merged
rachmari merged 2 commits into
github:mainfrom
paulyhedral:patch-1
Oct 10, 2020
Merged

Update workflow-commands-for-github-actions.md#216
rachmari merged 2 commits into
github:mainfrom
paulyhedral:patch-1

Conversation

@paulyhedral

@paulyhedral paulyhedral commented Oct 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

While a meter for delis would be incredibly useful for determining the best sandwich shop, a delimiter is better for dividing multiline strings.

Why:

Correcting misspelling in text.

What's being changed:

Spelling changed from delimeter to delimiter.

Check off the following:

@paulyhedral
Update workflow-commands-for-github-actions.md
794f479 
While a meter for delis would be incredibly useful for determining the best sandwich shop, a delimiter is better for dividing multiline strings.
@welcome

welcome Bot commented Oct 7, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

janiceilene commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Thanks for opening this up @paulyhedral 🥪 Could you fill out the pull request template and then I'll get this up for review!

@paulyhedral

paulyhedral commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

Filled in remainder of pull request template.

@janiceilene

janiceilene commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

Thanks @paulyhedral 💛 I'll let the @github/docs-content-ecosystem team know this is ready for review!

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 9, 2020
rachmari
rachmari approved these changes Oct 10, 2020
View reviewed changes

@rachmari rachmari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulyhedral Deli meter 😆 👏 I did laugh out loud when reading this so thank you for that, but also thank you for finding this one and fixing it up! 💚 :octocat:

I'll get this merged!! 🚢 🚀

@rachmari rachmari self-assigned this Oct 10, 2020
@rachmari rachmari merged commit b25f81e into github:main Oct 10, 2020
@janiceilene

janiceilene commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@paulyhedral

paulyhedral commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

@all-contributors please add @paulyhedral for content

@allcontributors allcontributors Bot mentioned this pull request Oct 13, 2020
Merged
@allcontributors

allcontributors Bot commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

@paulyhedral

I've put up a pull request to add @paulyhedral! 🎉

@paulyhedral paulyhedral deleted the patch-1 branch October 13, 2020 15:12
This was referenced Jan 21, 2021
Open
Open
@rhsayem075 rhsayem075 mentioned this pull request Jan 26, 2021
Open
This was referenced Jan 27, 2021
Open
Open
Open
@YoYBaBy YoYBaBy mentioned this pull request Feb 3, 2021
Open
@Link- Link- mentioned this pull request Mar 29, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rachmari rachmari rachmari approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rachmari rachmari

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulyhedral @janiceilene @rachmari