Skip to content

repo sync #20288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Octomerger merged 4 commits into from
Aug 30, 2022
Merged

repo sync #20288

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdd9bf3
Merge branch 'main' into repo-sync
Octomerger Aug 30, 2022
523ed4f
Merge pull request #30378 from github/repo-sync
Octomerger Aug 30, 2022
21cb630
SARIF Rule Identifier can't be the empty string #4283 (#29717)
hharen Aug 30, 2022
bbba9f2
Merge branch 'main' into repo-sync
Octomerger Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ You can check a SARIF file is compatible with {% data variables.product.prodname

If you use a code analysis engine other than {% data variables.product.prodname_codeql %}, you can review the supported SARIF properties to optimize how your analysis results will appear on {% data variables.product.prodname_dotcom %}.

{% note %}

**Note:** You must supply an explicit value for any property marked as "required". The empty string is not supported for required properties.

{% endnote %}

Any valid SARIF 2.1.0 output file can be uploaded, however, {% data variables.product.prodname_code_scanning %} will only use the following supported properties.

### `sarifLog` object
Expand Down Expand Up @@ -210,7 +216,7 @@ These example SARIF output files show supported properties and example values.

### Example with minimum required properties

This SARIF output file has example values to show the minimum required properties for {% data variables.product.prodname_code_scanning %} results to work as expected. If you remove any properties or don't include values, this data will not be displayed correctly or sync on {% data variables.product.prodname_dotcom %}.
This SARIF output file has example values to show the minimum required properties for {% data variables.product.prodname_code_scanning %} results to work as expected. If you remove any properties, omit values, or use an empty string, this data will not be displayed correctly or sync on {% data variables.product.prodname_dotcom %}.

```json
{
Expand Down