Skip to content

repo sync #20260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Octomerger merged 4 commits into from
Aug 29, 2022
Merged

repo sync #20260

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfd1041
add another early access breadcrumb exception
sarahs Aug 26, 2022
c4bc708
Merge pull request #30350 from github/repo-sync
Octomerger Aug 29, 2022
12a7506
Merge branch 'main' into early-access-product-breadcrumbs
sarahs Aug 29, 2022
4e7fa7f
Merge pull request #30304 from github/early-access-product-breadcrumbs
sarahs Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions middleware/contextualizers/breadcrumbs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export default async function breadcrumbs(req, res, next) {
return next()
}

const earlyAccessExceptions = ['insights', 'enterprise-importer']

async function getBreadcrumbs(req, isEarlyAccess = false) {
const crumbs = []
const { currentPath, currentVersion } = req.context
Expand All @@ -30,11 +32,11 @@ async function getBreadcrumbs(req, isEarlyAccess = false) {
// top-level like "/github"
cutoff++

// The only exception to this rule is for the
// /{version}/early-access/insights/... URLs because they're a
// There are a few exceptions to this rule for the
// /{version}/early-access/<product-name>/... URLs because they're a
// bit different.
// If there are more known exceptions, extend this conditional.
if (!split.includes('insights')) {
// If there are more known exceptions, add them to the array above.
if (!earlyAccessExceptions.some((product) => split.includes(product))) {
cutoff++
}

Expand Down