Skip to content

Improve "Configuring a subdomain" section#20146

Merged
sophietheking merged 2 commits into
github:mainfrom
vincent-czi:patch-2
Aug 30, 2022
Merged

Improve "Configuring a subdomain" section#20146
sophietheking merged 2 commits into
github:mainfrom
vincent-czi:patch-2

Conversation

@vincent-czi

@vincent-czi vincent-czi commented Aug 25, 2022 •
edited by cmwilson21
Loading

Copy link
Copy Markdown
Contributor

Current version has two different www subdomain examples, but I think the intention was for second subdomain example to be a non-www case. Looks like it was supposed to be another used as the subdomain in the second example, but instead the domain name was changed instead (www.example.com becoming www.anotherexample.com).

Why:

Closes 20145
See above description. Filed an issue as well here: #20145

What's being changed (if available, include any code snippets, screenshots, or gifs):

Instead of it being www.anotherexample.com as the second subdomain example (a second www example), making it another.example.com so it's a different subdomain.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@vincent-czi
Improve "Configuring a subdomain" section
8a795d4 
Current version has two different `www` subdomain examples, but I think the intention was for second subdomain example to be a non-`www` case. Looks like it was supposed to be `another` used as the subdomain in the second example, but instead the domain name was changed instead (`www.example.com` becoming `www.anotherexample.com`).
@welcome

welcome Bot commented Aug 25, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 25, 2022
@github-actions

github-actions Bot commented Aug 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21

cmwilson21 commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

@vincent-czi Thanks for opening a PR and an issue! I've edited your post slightly to link the two together.

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Aug 25, 2022
sophietheking
sophietheking approved these changes Aug 30, 2022
View reviewed changes

@sophietheking sophietheking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincent-czi 👋 thanks for opening this PR and improving our docs. We really appreciate it! 💖

This looks good to me, so I'll go ahead and get this merged. 🚀

@sophietheking sophietheking removed the waiting for review Issue/PR is waiting for a writer's review label Aug 30, 2022
@sophietheking sophietheking merged commit 89d901d into github:main Aug 30, 2022
@github-actions

github-actions Bot commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Managing Custom domain page > "Configuring a subdomain" > second example undifferentiated from first example

3 participants

@vincent-czi @cmwilson21 @sophietheking