Skip to content

Change branches to branches/tags #20048

Merged
hubwriter merged 5 commits into
github:mainfrom
Phantsure:patch-2
Aug 30, 2022
Merged

Change branches to branches/tags #20048
hubwriter merged 5 commits into
github:mainfrom
Phantsure:patch-2

Conversation

@Phantsure

@Phantsure Phantsure commented Aug 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

Closes actions/cache#556
cc @bishal-pdMSFT

What's being changed (if available, include any code snippets, screenshots, or gifs):

Cache cannot be shared between sibling branches and tags. The documentation doesn't account for tags.
Note: There is a Japanese translation as well for this document. A little unsure how that can be updated

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome

welcome Bot commented Aug 22, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 22, 2022
@github-actions

github-actions Bot commented Aug 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/caching-dependencies-to-speed-up-workflows.md fpt
ghec
ghes@ 3.6 3.5
fpt
ghec
ghes@ 3.6 3.5

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

bishal-pdMSFT
bishal-pdMSFT reviewed Aug 22, 2022
View reviewed changes
Comment thread content/actions/using-workflows/caching-dependencies-to-speed-up-workflows.md Outdated
@Sakhilemasina

This comment was marked as spam.

Sign in to view
@Phantsure
Add more explanation
d84342f 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@cmwilson21

cmwilson21 commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

👋 @Phantsure Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 22, 2022
PIYUSH-MISHRA-00
PIYUSH-MISHRA-00 reviewed Aug 26, 2022
View reviewed changes

@PIYUSH-MISHRA-00 PIYUSH-MISHRA-00 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

included tags

hubwriter
hubwriter reviewed Aug 30, 2022
View reviewed changes
Comment thread content/actions/using-workflows/caching-dependencies-to-speed-up-workflows.md Outdated
hubwriter
hubwriter approved these changes Aug 30, 2022
View reviewed changes

@hubwriter hubwriter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phantsure - Many thanks for raising this PR.

I'll get this merged/published.

@hubwriter hubwriter enabled auto-merge (squash) August 30, 2022 11:56
@hubwriter hubwriter merged commit 046683c into github:main Aug 30, 2022
@github-actions

github-actions Bot commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hubwriter hubwriter hubwriter approved these changes
+2 more reviewers
@bishal-pdMSFT bishal-pdMSFT bishal-pdMSFT left review comments
@PIYUSH-MISHRA-00 PIYUSH-MISHRA-00 PIYUSH-MISHRA-00 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

using cache on tags does not work

6 participants

@Phantsure @Sakhilemasina @cmwilson21 @bishal-pdMSFT @hubwriter @PIYUSH-MISHRA-00