Skip to content

Remove unneeded permission in auto-merge example - #17375

Merged
mchammer01 merged 3 commits into
github:mainfrom
felipecrs:patch-2
Apr 28, 2022
Merged

Remove unneeded permission in auto-merge example#17375
mchammer01 merged 3 commits into
github:mainfrom
felipecrs:patch-2

Conversation

@felipecrs

@felipecrs felipecrs commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

And simplify the workflow a little.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@felipecrs
Remove unneeded permission in auto-merge example
2f53257 
And simplify the workflow a little.
@welcome

welcome Bot commented Apr 26, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 26, 2022
@github-actions

github-actions Bot commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions.md Modified Original

@felipecrs

felipecrs commented Apr 26, 2022

Copy link
Copy Markdown
Contributor Author

I tested this in https://github.com/vscode-shellcheck/vscode-shellcheck/blob/master/.github/workflows/dependabot-auto-merge.yaml

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Apr 26, 2022
@ramyaparimi

ramyaparimi commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

@felipecrs
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@felicitymay

felicitymay commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

@ramyaparimi - since this deals with actions and permissions, this will need an SME review from either actions and/or Dependabot.

@felicitymay felicitymay added the needs SME This proposal needs review from a subject matter expert label Apr 27, 2022
@github-actions

github-actions Bot commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@mchammer01 mchammer01 self-assigned this Apr 27, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team dependabot Content related to Dependabot labels Apr 27, 2022
mchammer01
mchammer01 reviewed Apr 28, 2022
View reviewed changes

@mchammer01 mchammer01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felipecrs - thanks for your contribution ✨
I've accepted the change about the permission but will revert the updates made to ${{ following consultation with the Dependabot team. You are right in that we could remove these but most of our examples throughout the docs contain them so we'll keep them for consistency for now.
Thanks again for helping us improve our docs!

Comment thread ...ode-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions.md Outdated
Comment thread ...ode-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions.md Outdated
Comment thread ...ode-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions.md Outdated
Comment thread ...ode-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions.md Outdated
mchammer01
mchammer01 approved these changes Apr 28, 2022
View reviewed changes

@mchammer01 mchammer01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mchammer01
mchammer01 enabled auto-merge April 28, 2022 06:28
@mchammer01
mchammer01 merged commit a530300 into github:main Apr 28, 2022
@github-actions

github-actions Bot commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@felipecrs
felipecrs deleted the patch-2 branch April 28, 2022 15:14
@felipecrs

felipecrs commented Apr 28, 2022

Copy link
Copy Markdown
Contributor Author

@mchammer01 it makes sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees

@mchammer01 mchammer01

Labels

actions This issue or pull request should be reviewed by the docs actions team code security Content related to code security content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felipecrs @ramyaparimi @felicitymay @mchammer01