This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Fix specified default parameter value#93
Merged
Conversation
Given that the call gets the public repositories of the specified user, it doesn't make sense that the default value of type would be 'public' which isn't even listed as an option. Instead it makes more sense that it would default to 'all' since you could then narrow down the search to 'owner' or 'member'.
pengwynn
added a commit
that referenced
this pull request
May 31, 2012
Fix specified default parameter value
izuzak
added a commit
that referenced
this pull request
Feb 25, 2014
Pull requests can't be created if base is not a branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the call gets the public repositories of the specified user, it
doesn't make sense that the default value of type would be 'public' which
isn't even listed as an option. Instead it makes more sense that it would
default to 'all' since you could then narrow down the search to 'owner' or
'member'.