Skip to content

Use virtual threads by default on Java 21+ via Multi-Release JAR #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 9 commits into from
Closed

Use virtual threads by default on Java 21+ via Multi-Release JAR #60

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
caaf6d6
Initial plan
Copilot Apr 7, 2026
4ae4200
Add virtual thread support on Java 21+ via Multi-Release JAR
Copilot Apr 7, 2026
ce4fd3d
Address code review feedback: use assertFalse, simplify README
Copilot Apr 7, 2026
af2540d
Update README.md
brunoborges Apr 7, 2026
25829a4
Update src/test/java/com/github/copilot/sdk/ThreadFactoryProviderTest…
brunoborges Apr 7, 2026
fef1833
s
brunoborges Apr 7, 2026
9d456f6
Remove unused LOG fields, use newSingleThreadExecutor for Java 21 ove…
Copilot Apr 7, 2026
e10745e
Potential fix for pull request finding 'Useless comparison test'
brunoborges Apr 10, 2026
14b0ed9
Merge remote-tracking branch 'origin/main' into copilot/copilot-pr-60
edburns Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review feedback: use assertFalse, simplify README 
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/e74714e4-bb84-4af7-b1ef-44f576c5b37c

Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
  • Loading branch information
@brunoborges
Copilot and brunoborges authored Apr 7, 2026
commit ce4fd3d7b0983cce5a6a5af1b85c899703ffa081
12 changes: 3 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Java SDK for programmatic control of GitHub Copilot CLI, enabling you to build A

### Requirements

- Java 17 or later. **JDK 21+ recommended** for automatic virtual thread support (see [Virtual Threads](#virtual-threads) below). Selecting JDK 25 additionally enables the use of virtual threads for the custom executor, as shown in the [Quick Start](#quick-start).
- Java 17 or later. **JDK 21+ recommended** — the SDK automatically uses virtual threads for its internal I/O on Java 21+ (see [Virtual Threads](#virtual-threads)).
Comment thread
brunoborges marked this conversation as resolved.
Outdated
- GitHub Copilot CLI 1.0.17 or later installed and in `PATH` (or provide custom `cliPath`)

### Maven
Expand Down Expand Up @@ -69,23 +69,17 @@ implementation 'com.github:copilot-sdk-java:0.2.1-java.1'
import com.github.copilot.sdk.CopilotClient;
import com.github.copilot.sdk.events.AssistantMessageEvent;
import com.github.copilot.sdk.events.SessionUsageInfoEvent;
import com.github.copilot.sdk.json.CopilotClientOptions;
import com.github.copilot.sdk.json.MessageOptions;
import com.github.copilot.sdk.json.PermissionHandler;
import com.github.copilot.sdk.json.SessionConfig;

import java.util.concurrent.Executors;

public class CopilotSDK {
public static void main(String[] args) throws Exception {
var lastMessage = new String[]{null};

// Create and start client
try (var client = new CopilotClient()) { // JDK 25+: comment out this line
// JDK 25+: uncomment the following 3 lines for virtual thread support
// var options = new CopilotClientOptions()
// .setExecutor(Executors.newVirtualThreadPerTaskExecutor());
// try (var client = new CopilotClient(options)) {
// On Java 21+, the SDK automatically uses virtual threads for internal I/O.
try (var client = new CopilotClient()) {
client.start().get();

// Create a session
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/github/copilot/sdk/ThreadFactoryProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package com.github.copilot.sdk;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

Expand Down Expand Up @@ -56,7 +57,7 @@ void isVirtualThreadsReturnsBoolean() {
if (javaVersion >= 21) {
assertTrue(result, "Expected virtual threads on Java 21+");
} else {
assertTrue(!result, "Expected platform threads on Java < 21");
assertFalse(result, "Expected platform threads on Java < 21");
}
}
}
Loading