Skip to content

Edburns/re enable pre commit hooks #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edburns merged 3 commits into from
Apr 6, 2026
Merged

Edburns/re enable pre commit hooks #49

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bd084c
Reapply "On branch edburns/spotless-agentic-workflow-42"
edburns Mar 31, 2026
99d4567
Reapply "Update .github/workflows/copilot-setup-steps.yml"
edburns Mar 31, 2026
e665e21
On branch edburns/re-enable-pre-commit-hooks
edburns Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
On branch edburns/re-enable-pre-commit-hooks 
modified:   .github/copilot-instructions.md

Apply @Copilot review recommendation.

> This new section says the pre-commit hook is “automatically enabled” via `copilot-setup-steps.yml`, but earlier in the same document (and in CONTRIBUTING/README) the hook is described as something developers must manually enable with `git config core.hooksPath .githooks`. Please clarify the scope (e.g., auto-enabled only in the Copilot coding agent environment; local development still requires manual enablement) to avoid conflicting guidance, and consider linking explicitly to `.github/workflows/copilot-setup-steps.yml` for precision.

Signed-off-by: Ed Burns <edburns@microsoft.com>
  • Loading branch information
@edburns
edburns committed Apr 6, 2026
commit e665e2100ab90262ba9e3a4d2fc04ca1f45c339e
2 changes: 1 addition & 1 deletion .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ When porting from .NET:
- 4-space indentation (enforced by Spotless with Eclipse formatter)
- Fluent setter pattern for configuration classes (e.g., `new SessionConfig().setModel("gpt-5").setTools(tools)`)
- Public APIs require Javadoc (enforced by Checkstyle, except `json` and `events` packages)
- Pre-commit hook runs `mvn spotless:check` - enable with: `git config core.hooksPath .githooks`
- Pre-commit hook runs `mvn spotless:check` - Must be manually enabled with: `git config core.hooksPath .githooks`, except in the Copilot coding agent environment. This hook is explicitly enabled in the Copilot coding agent environment. See [copilot-setup-steps.yml](workflows/copilot-setup-steps.yml).

### Handler Pattern

Expand Down
Loading