Skip to content

Add **Shared ScheduledExecutorService** for timeouts #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7 commits merged into from
Mar 30, 2026
Merged

Add **Shared ScheduledExecutorService** for timeouts #36

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c405b7
On branch edburns/dd-2758695-virtual-threads Add **Shared `ScheduledE…
edburns Mar 27, 2026
a36d145
On branch edburns/dd-2758695-virtual-threads Add **Shared `ScheduledE…
edburns Mar 27, 2026
9e102bc
Fix memory leak from cancelled timeout tasks in CopilotSession
edburns Mar 27, 2026
a1668c7
Fix scheduler memory leak and close() race condition in CopilotSession
edburns Mar 27, 2026
a01f0b5
Honor documented contract: timeoutMs <= 0 means no timeout in sendAnd…
edburns Mar 27, 2026
9dc5933
Prevent CopilotSession leak on assertion failure in TimeoutEdgeCaseTest
edburns Mar 27, 2026
075df31
spotless
edburns Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix memory leak from cancelled timeout tasks in CopilotSession 
Replace Executors.newSingleThreadScheduledExecutor with an explicit
ScheduledThreadPoolExecutor so we can enable removeOnCancelPolicy(true).
Without this, each call to sendAndWait() that completes normally cancels
its timeout task, but the cancelled task remains in the scheduler's work
queue, leaking memory over the lifetime of the session.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Ed Burns <edburns@microsoft.com>
  • Loading branch information
@edburns
edburns and Copilot committed Mar 27, 2026
commit 9e102bcba86fb156060a90c7ba0c0a87136953c7
5 changes: 4 additions & 1 deletion src/main/java/com/github/copilot/sdk/CopilotSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicReference;
Expand Down Expand Up @@ -159,11 +160,13 @@ public final class CopilotSession implements AutoCloseable {
this.sessionId = sessionId;
this.rpc = rpc;
this.workspacePath = workspacePath;
this.timeoutScheduler = Executors.newSingleThreadScheduledExecutor(r -> {
var executor = new ScheduledThreadPoolExecutor(1, r -> {
var t = new Thread(r, "sendAndWait-timeout");
t.setDaemon(true);
return t;
});
executor.setRemoveOnCancelPolicy(true);
this.timeoutScheduler = executor;
}

/**
Expand Down
Loading