Skip to content

Fix compilation errors from PermissionRequestResultKind enum-to-class refactor #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edburns merged 3 commits into from
Mar 24, 2026
Merged

Fix compilation errors from PermissionRequestResultKind enum-to-class refactor #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2edf741
Initial plan
Copilot Mar 24, 2026
720cc87
Fix compilation errors: PermissionRequestResultKind valueOf/name to c…
Copilot Mar 24, 2026
abf63cd
Merge branch 'copilot/sync-upstream-39-new-commits' into copilot/fix-…
edburns Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compilation errors: PermissionRequestResultKind valueOf/name to c… 
…onstructor/getValue

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/bd5aed59-ed6b-446f-b070-7f09633c74cd
  • Loading branch information
@edburns
Copilot and edburns authored Mar 24, 2026
commit 720cc87973cbec7935d4129d542f906c9c76a811
2 changes: 1 addition & 1 deletion src/main/java/com/github/copilot/sdk/CopilotSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ private void executePermissionAndRespondAsync(String requestId, PermissionReques
invocation.setSessionId(sessionId);
handler.handle(permissionRequest, invocation).thenAccept(result -> {
try {
PermissionRequestResultKind kind = PermissionRequestResultKind.valueOf(result.getKind());
PermissionRequestResultKind kind = new PermissionRequestResultKind(result.getKind());
if (PermissionRequestResultKind.NO_RESULT.equals(kind)) {
// Handler explicitly abstains — leave the request unanswered
// so another client can handle it.
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/github/copilot/sdk/RpcHandlerDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ private void handlePermissionRequest(JsonRpcClient rpc, String requestId, JsonNo

session.handlePermissionRequest(permissionRequest).thenAccept(result -> {
try {
if (PermissionRequestResultKind.NO_RESULT.name().equals(result.getKind())) {
if (PermissionRequestResultKind.NO_RESULT.getValue().equalsIgnoreCase(result.getKind())) {
// Handler explicitly abstains — do not send a response,
// allowing another client to handle the request.
return;
Expand Down
Loading