Fix Dependabot alert #18: upgrade js-yaml to 4.2.0 via override#8
Merged
Merged
Conversation
Add npm override for js-yaml ^4.2.0 to resolve CVE-2026-53550, a quadratic-complexity DoS vulnerability in merge key handling. The vulnerable js-yaml <=4.1.1 was a transitive dev dependency via @istanbuljs/load-nyc-config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Node.js dependency resolution to address Dependabot alert #18 by forcing a patched js-yaml version via npm overrides, and updates the lockfile accordingly.
Changes:
- Add an npm
overridesentry to forcejs-yamlto^4.2.0. - Update
package-lock.jsonto reflectjs-yaml@4.2.0and its new transitive dependency graph (e.g.,argparse@2.0.1, removal ofesprima/sprintf-js).
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds an override to force js-yaml@^4.2.0 for the security fix. |
| package-lock.json | Locks js-yaml@4.2.0 and updates transitive dependencies impacted by the override. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 1
Comment on lines
29
to
33
| "overrides": { | ||
| "undici": "^6.24.1", | ||
| "handlebars": "^4.7.9" | ||
| "handlebars": "^4.7.9", | ||
| "js-yaml": "^4.2.0" | ||
| }, |
babakks
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves Dependabot alert #18 — CVE-2026-53550 (medium severity, CVSS 5.3).
Vulnerability
js-yaml≤ 4.1.1 is susceptible to a quadratic-complexity DoS via repeated alias merge keys (<<: [*a, *a, ...]), which can block the Node.js event loop with relatively small payloads.Fix
Added an npm
overrideforjs-yaml→^4.2.0, which includes the fix. The vulnerablejs-yaml3.14.2 was a transitive dev dependency pulled in via@istanbuljs/load-nyc-config(used by Jest/Istanbul for coverage). Since the latest version of that package still pins^3.13.1, an override is the appropriate fix.Testing
All 42 existing tests pass with the upgraded dependency.