Switch getting job details from a GET to a POST#17
Open
Chuxel wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PlatformClient.fetchJobDetails() request to use POST instead of GET when retrieving job details from the platform API, aligning the SDK with an internal endpoint change.
Changes:
- Switch
fetchJobDetails()HTTP method fromGETtoPOST.
Show a summary per file
| File | Description |
|---|---|
src/client.ts |
Changes the job-details request method to POST to match the updated platform endpoint behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
462
to
465
| const response = await fetch(url.toString(), { | ||
| method: "GET", | ||
| method: "POST", | ||
| headers: this.headers, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of internal updates to this endpoint.