Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
af767ec
Add overlay_analysis_min_disk_N_gb feature flags
henrymercer Aug 6, 2026
6117bb5
Derive overlay minimum disk space from feature flags
henrymercer Aug 6, 2026
99caaa8
Remove the overlay_analysis_resource_checks_v2 feature flag
henrymercer Aug 6, 2026
5410981
Address review feedback on the disk space check
henrymercer Aug 6, 2026
794f5bc
Fix the memory check debug message at equality
henrymercer Aug 6, 2026
5f8c44b
Persist CodeQL version output to file rather than environment
mario-campos Aug 7, 2026
9183a7b
Handle file-read errors as cache misses
mario-campos Aug 10, 2026
208a88a
Simplify JSDoc of `getCachedCodeQlVersion`
mario-campos Aug 11, 2026
bfcd769
Fix JSDoc of `env` param
mario-campos Aug 11, 2026
0e85c0e
Refactor unit test to extract testing values
mario-campos Aug 11, 2026
bb19330
Add test of `getCachedCodeQlVersion` with no file
mario-campos Aug 11, 2026
4dc327a
Introduce basic `cli/output-cache.ts` module
mario-campos Aug 11, 2026
1332611
Move cache-related util functions into dedicated module
mario-campos Aug 11, 2026
246018e
Move `VersionInfo` to dedicated module
mario-campos Aug 11, 2026
0a99875
Move `VersionInfo`-related types to `cli/output-cache.ts`
mario-campos Aug 11, 2026
11569df
Update JSDoc of `getCachedCodeQlVersion`
mario-campos Aug 11, 2026
b222c3a
Generalize file cache data structure
mario-campos Aug 11, 2026
40f80a8
Rename type to better match generic intention
mario-campos Aug 11, 2026
33d7086
Pass environment explicitly to CLI caching functions
mario-campos Aug 12, 2026
a9baab8
Export CLI cache types
mario-campos Aug 12, 2026
337136a
Rename `CommandCacheRecord` -> `OutputCache`
mario-campos Aug 12, 2026
bf96b0d
Expand test to ensure it does not throw an exception
mario-campos Aug 12, 2026
6c0d901
Change `OutputCache` to use object for `entries`
mario-campos Aug 12, 2026
6dc6332
Bolster output-cache unit tests with more test cases
mario-campos Aug 12, 2026
2d49edb
Re-order `env` to be first argument for consistency
mario-campos Aug 13, 2026
1158e1c
Update changelog and version after v4.37.7
github-actions[bot] Aug 13, 2026
053d41e
Rebuild
github-actions[bot] Aug 13, 2026
5008eff
Merge pull request #4094 from github/mergeback/v4.37.7-to-main-ff2f1c62
mbg Aug 13, 2026
43250d6
Change cache key to string type to include CLI args
mario-campos Aug 13, 2026
aa0eadc
Merge branch 'main' into mario-campos/version-cache-to-disk
mario-campos Aug 13, 2026
c56f48e
Log unexpected conditions during caching CLI output
mario-campos Aug 13, 2026
c2fd8f5
Merge pull request #4081 from github/mario-campos/version-cache-to-disk
mario-campos Aug 13, 2026
45693cc
Refactor `ENOSPC` check into `isDiskConfigurationError` function
mbg Aug 14, 2026
47fa622
Make `EACCES` a `ConfigurationError`
mbg Aug 14, 2026
d97b342
Merge pull request #4098 from github/mbg/permission-error-as-configur…
mbg Aug 14, 2026
508b83b
Merge main into overlay minimum disk feature branch
henrymercer Aug 18, 2026
1aef003
Address review feedback on overlay disk flags
henrymercer Aug 18, 2026
9ee088e
Merge pull request #4080 from github/henrymercer/studious-giggle
henrymercer Aug 18, 2026
1845f5b
Update changelog for v4.37.8
github-actions[bot] Aug 21, 2026
db488dd
Merge pull request #4102 from github/update-v4.37.8-9ee088e13
henrymercer Aug 21, 2026
77571dc
Revert "Update version and changelog for v3.37.7"
github-actions[bot] Aug 21, 2026
2b5f0e6
Revert "Rebuild"
github-actions[bot] Aug 21, 2026
57a845c
Merge remote-tracking branch 'origin/releases/v4' into backport-v3.37…
github-actions[bot] Aug 21, 2026
0692998
Update version and changelog for v3.37.8
github-actions[bot] Aug 21, 2026
771aacb
Rebuild
github-actions[bot] Aug 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move VersionInfo to dedicated module
  • Loading branch information
mario-campos committed Aug 11, 2026
commit 246018e04157a8b7531c3d25384b2da6f29083ed
3 changes: 2 additions & 1 deletion src/cli/output-cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ import * as fs from "fs";
import path from "path";

import { getTemporaryDirectory } from "../actions-util";
import { VersionInfo } from "../codeql";
import { Env, getEnv } from "../environment";
import { isPersistedVersionInfo } from "../util";

import type { VersionInfo } from "./types";

/**
* The name of the temporary file that backs the on-disk cache of
* CLI responses between workflow steps.
Expand Down
13 changes: 13 additions & 0 deletions src/cli/types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
export interface VersionInfo {
version: string;
features?: { [name: string]: boolean };
/**
* The overlay version helps deal with backward incompatible changes for
* overlay analysis. When a precompiled query pack reports the same overlay
* version as the CodeQL CLI, we can use the CodeQL CLI to perform overlay
* analysis with that pack. Otherwise, if the overlay versions are different,
* or if either the pack or the CLI does not report an overlay version,
* we need to revert to non-overlay analysis.
*/
overlayVersion?: number;
}
15 changes: 1 addition & 14 deletions src/codeql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
} from "./actions-util";
import * as api from "./api-client";
import * as outputCache from "./cli/output-cache";
import type { VersionInfo } from "./cli/types";
import { CliError, wrapCliConfigurationError } from "./cli-errors";
import { appendExtraQueryExclusions, type Config } from "./config-utils";
import { DocUrl } from "./doc-url";
Expand Down Expand Up @@ -216,20 +217,6 @@ export interface CodeQL {
): Promise<void>;
}

export interface VersionInfo {
version: string;
features?: { [name: string]: boolean };
/**
* The overlay version helps deal with backward incompatible changes for
* overlay analysis. When a precompiled query pack reports the same overlay
* version as the CodeQL CLI, we can use the CodeQL CLI to perform overlay
* analysis with that pack. Otherwise, if the overlay versions are different,
* or if either the pack or the CLI does not report an overlay version,
* we need to revert to non-overlay analysis.
*/
overlayVersion?: number;
}

export interface ResolveDatabaseOutput {
overlayBaseSpecifier?: string;
}
Expand Down
3 changes: 2 additions & 1 deletion src/testing-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import * as apiClient from "./api-client";
import { GitHubApiDetails } from "./api-client";
import { CachingKind } from "./caching-utils";
import { resetCachedCodeQlVersion } from "./cli/output-cache";
import type { VersionInfo } from "./cli/types";
import * as codeql from "./codeql";
import { Config } from "./config-utils";
import * as defaults from "./defaults.json";
Expand Down Expand Up @@ -872,7 +873,7 @@ export const makeVersionInfo = (
version: string,
features?: { [name: string]: boolean },
overlayVersion?: number,
): codeql.VersionInfo => ({
): VersionInfo => ({
version,
features,
overlayVersion,
Expand Down
2 changes: 1 addition & 1 deletion src/tools-features.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as semver from "semver";

import type { VersionInfo } from "./codeql";
import type { VersionInfo } from "./cli/types";

export enum ToolsFeature {
BuiltinExtractorsSpecifyDefaultQueries = "builtinExtractorsSpecifyDefaultQueries",
Expand Down
3 changes: 2 additions & 1 deletion src/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import * as yaml from "js-yaml";
import * as semver from "semver";

import * as apiCompatibility from "./api-compatibility.json";
import type { CodeQL, VersionInfo } from "./codeql";
import type { VersionInfo } from "./cli/types";
import type { CodeQL } from "./codeql";
import type { Pack } from "./config/db-config";
import type { Config } from "./config-utils";
import { EnvVar, getRequiredEnvParam } from "./environment";
Expand Down