Skip to content

Extend start-proxy.yml to test multiple registry support #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 7 commits into from
Apr 1, 2026
+36 −2
Merged

Extend start-proxy.yml to test multiple registry support #3792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c7c298
Extend start-proxy.yml to test multiple registry support
mario-campos Mar 30, 2026
9fd9b64
Replace `jq` with Actions expression for proxy_urls validation
mario-campos Mar 31, 2026
99b8dd4
Run `pr-checks/sync.sh` to generate __start-proxy.yml.
mario-campos Mar 31, 2026
8b5e604
Use `maven_repository`, not `maven-repository`
mario-campos Mar 31, 2026
faf45e0
Use different maven URL for start-proxy.yml test
mario-campos Mar 31, 2026
7b0c5b1
Keep validation steps named consistently
mario-campos Mar 31, 2026
e2203c6
Delete `fromJSON()` calls in test validation step
mario-campos Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use maven_repository, not maven-repository 
The registry/language mapping table does not map the one with hyphens.
  • Loading branch information
@mario-campos
mario-campos committed Mar 31, 2026
commit 8b5e60477ca43ab05e54c7f7290e85a1c442593f
6 changes: 3 additions & 3 deletions .github/workflows/__start-proxy.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pr-checks/checks/start-proxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ steps:
registry_secrets: |
[
{
"type": "maven-repository",
"type": "maven_repository",
"url": "https://acme.jfrog.io/artifactory/my-maven-registry"
},
{
"type": "maven-repository",
"type": "maven_repository",
"url": "https://repo1.maven.org/maven2"
}
]
Expand All @@ -40,7 +40,7 @@ steps:

- name: Validate proxy_urls contains expected registries
if: |
join(fromJSON(steps.proxy.outputs.proxy_urls)[*].type, ',') != 'maven-repository,maven-repository'
join(fromJSON(steps.proxy.outputs.proxy_urls)[*].type, ',') != 'maven_repository,maven_repository'
|| !contains(fromJSON(steps.proxy.outputs.proxy_urls)[*].url, 'https://acme.jfrog.io/artifactory/my-maven-registry')
|| !contains(fromJSON(steps.proxy.outputs.proxy_urls)[*].url, 'https://repo1.maven.org/maven2')
run: exit 1
Comment thread
mbg marked this conversation as resolved.