Skip to content

Prepare for rolling out skipping computing file coverage information on PRs #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 12 commits into from
Mar 11, 2026
Merged

Prepare for rolling out skipping computing file coverage information on PRs #3562

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c102a6d
Require tools feature flag
henrymercer Mar 9, 2026
9e8c059
Add ability to override via repository property
henrymercer Mar 9, 2026
a3fdd0e
Add telemetry diagnostic to track whether repo property is used
henrymercer Mar 9, 2026
6773afd
Add changelog note
henrymercer Mar 9, 2026
3592fe5
Address review comments
henrymercer Mar 9, 2026
3d2bdbb
Simplify default repo properties
henrymercer Mar 10, 2026
55ae117
Reduce duplication of `getFileCoverageInformationEnabled`
henrymercer Mar 10, 2026
ce321da
Merge branch 'main' into henrymercer/skip-file-coverage-rollout
henrymercer Mar 10, 2026
bef08ed
Update to log deprecation warning
henrymercer Mar 10, 2026
55a0f2b
Add environment variable override
henrymercer Mar 10, 2026
e07c305
Tweak changelog formatting
henrymercer Mar 10, 2026
a11c6cb
Merge branch 'main' into henrymercer/skip-file-coverage-rollout
henrymercer Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add telemetry diagnostic to track whether repo property is used
  • Loading branch information
@henrymercer
henrymercer committed Mar 9, 2026
commit a3fdd0e0b5ce795f906edcd17cb6453d14e531f4
10 changes: 10 additions & 0 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions src/init-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
getOptionalInput,
getRequiredInput,
getTemporaryDirectory,
isAnalyzingPullRequest,
persistInputs,
} from "./actions-util";
import { AnalysisKind, getAnalysisKinds } from "./analyses";
Expand Down Expand Up @@ -42,6 +43,7 @@ import { Feature, FeatureEnablement, initFeatures } from "./feature-flags";
import {
loadPropertiesFromApi,
RepositoryProperties,
RepositoryPropertyName,
} from "./feature-flags/properties";
import {
checkInstallPython311,
Expand Down Expand Up @@ -398,6 +400,23 @@ async function run(startedAt: Date) {
);
}

if (
config.enableFileCoverageInformation &&
isAnalyzingPullRequest() &&
repositoryPropertiesResult.orElse({})[
RepositoryPropertyName.FILE_COVERAGE_ON_PRS
] === true
Comment thread
henrymercer marked this conversation as resolved.
Outdated
) {
addNoLanguageDiagnostic(
config,
makeTelemetryDiagnostic(
"codeql-action/file-coverage-on-prs-enabled-by-repository-property",
"File coverage on PRs enabled by repository property",
{},
),
);
}

await checkInstallPython311(config.languages, codeql);
} catch (unwrappedError) {
const error = wrapError(unwrappedError);
Expand Down