Skip to content

Fix handling of non-string values from repository properties API #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 7 commits into from
Mar 9, 2026
+126 −36
Merged

Fix handling of non-string values from repository properties API #3557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e70ae2
Update `GitHubRepositoryProperty` to match schema
mbg Mar 9, 2026
9c75a5f
Only validate property `value` type if we care about the property
mbg Mar 9, 2026
5899159
Validate `value` types returned by API against expectations
mbg Mar 9, 2026
58314dc
Export types that weren't already
mbg Mar 9, 2026
5311ed4
Include type in error message
mbg Mar 9, 2026
149fd14
Add unknown property with `string[]` value
mbg Mar 9, 2026
6f90eb6
Add changelog entry
mbg Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include type in error message
  • Loading branch information
@mbg
mbg committed Mar 9, 2026
commit 5311ed41ea6559c31939a79deab8c6030b41cbaf
2 changes: 1 addition & 1 deletion lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/feature-flags/properties.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ test.serial(
),
{
message:
/Unexpected value for repository property 'github-codeql-extra-queries', got: 123/,
/Unexpected value for repository property 'github-codeql-extra-queries' \(number\), got: 123/,
},
);
},
Expand Down
2 changes: 1 addition & 1 deletion src/feature-flags/properties.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ function setProperty<K extends RepositoryPropertyName>(
properties[name] = propertyOptions.parse(name, value, logger);
} else {
throw new Error(
`Unexpected value for repository property '${name}', got: ${JSON.stringify(value)}`,
`Unexpected value for repository property '${name}' (${typeof value}), got: ${JSON.stringify(value)}`,
);
Comment thread
mbg marked this conversation as resolved.
}
Comment thread
mbg marked this conversation as resolved.
}
Expand Down