Skip to content

Add support for validation jobs to sync.ts, and refactor #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 20 commits into from
Mar 11, 2026
Merged

Add support for validation jobs to sync.ts, and refactor #3541

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5db3a9e
Extract `JobSpecification` type from `Specification`
mbg Mar 3, 2026
97a3705
Organise language-specific setup information
mbg Mar 3, 2026
369d73b
Refactor matrix generation into its own function
mbg Mar 3, 2026
92ab799
Refactor job generation into `generateJob`
mbg Mar 3, 2026
95fc2f1
Move `yq` setup code into `getSetupSteps`
mbg Mar 4, 2026
2b60771
Add support for additional, validation jobs
mbg Mar 3, 2026
56ebdff
Merge branch 'main' into mbg/pr-checks/validation-jobs
mbg Mar 5, 2026
3d47812
Add `tsconfig.json` for `pr-checks`
mbg Mar 5, 2026
79fdef7
Fix `generateValidationJobs` typing
mbg Mar 5, 2026
103db93
Make it more explicit that `getSetupSteps` just needs a `JobSpecifica…
mbg Mar 5, 2026
2a00604
Fix condition
mbg Mar 5, 2026
da11f44
Run `prepare-test` after setup steps
mbg Mar 9, 2026
5ddbbbe
Install python if there is no `matrix.version`
mbg Mar 9, 2026
8ba8180
Merge remote-tracking branch 'origin/main' into mbg/pr-checks/validat…
mbg Mar 9, 2026
b9b42be
Remove last use of `installPython`
mbg Mar 11, 2026
2e1f08f
Remove `installPython` condition in `sync.ts`
mbg Mar 11, 2026
be7fe2b
Make it more explicit by construction that known inputs always have t…
mbg Mar 11, 2026
6570ad3
Extend base `tsconfig.json`
mbg Mar 11, 2026
89f6321
Use `version` in error message
mbg Mar 11, 2026
d1a7580
Verify PR checks in a different job, with newer Node
mbg Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix condition
  • Loading branch information
@mbg
mbg committed Mar 5, 2026
commit 2a0060496cd11fc2992f8019e5f42e80dd109a86
2 changes: 1 addition & 1 deletion pr-checks/sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ function getSetupSteps(checkSpecification: JobSpecification): {

if (
setupSpec === undefined ||
checkSpecification[setupSpec.specProperty] === undefined
checkSpecification[setupSpec.specProperty] !== true
Copy link
Copy Markdown
Contributor

@esbena esbena Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
checkSpecification[setupSpec.specProperty] !== true
!checkSpecification[setupSpec.specProperty]

Copy link
Copy Markdown
Member Author

@mbg mbg Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference, but I generally prefer the explicit check due to JS weirdness about truthiness.

) {
continue;
}
Expand Down