Skip to content

C#: Cache temporary dependency directory for BMN #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 7 commits into from
Nov 26, 2025
Merged

C#: Cache temporary dependency directory for BMN #3286

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf8b7a6
Refactor C# cache content paths into a function
mbg Nov 12, 2025
d854ba6
Pass `FeatureEnablement` to `getDependencyPaths`
mbg Nov 12, 2025
a47d04c
Add FF for extra C# cache contents
mbg Nov 12, 2025
ecaa6db
Include `getCsharpTempDependencyDir` in C# caches if FF is enabled
mbg Nov 13, 2025
f5f9571
Configure temp dependency dir for C# extractor when FF is enabled
mbg Nov 13, 2025
0155561
Merge branch 'main' into mbg/csharp/more-cache-locations
mbg Nov 26, 2025
3e93966
Merge branch 'main' into mbg/csharp/more-cache-locations
henrymercer Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor C# cache content paths into a function
  • Loading branch information
@mbg
mbg committed Nov 13, 2025
commit cf8b7a6e14d039e1cb0f7b5afbe0f2830bab2c11
5 changes: 4 additions & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion src/dependency-caching.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,17 @@ export function getJavaDependencyDirs(): string[] {
];
}

/**
* Returns an array of paths of directories on the runner that should be included in a dependency cache
* for a C# analysis.
*
* @returns The paths of directories on the runner that should be included in a dependency cache
* for a C# analysis.
Comment on lines +82 to +86
Copy link
Copy Markdown
Contributor

@henrymercer henrymercer Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, here and elsewhere: avoid duplicating doc comments by just keeping the @returns paragraph.

Copy link
Copy Markdown
Member Author

@mbg mbg Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth the effort of changing here, but happy to reduce duplication going forward.

*/
Comment on lines +81 to +87
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a note similar to the one in getJavaDependencyDirs documentation (lines 54-56) explaining why this needs to be a function: "It is important that this is a function, because we call getTemporaryDirectory which would otherwise fail in tests if we haven't had a chance to initialise RUNNER_TEMP." This would improve consistency and help future maintainers understand the design decision.

Copilot uses AI. Check for mistakes.
export function getCsharpDependencyDirs(): string[] {
return [join(os.homedir(), ".nuget", "packages")];
}

/**
* Checks that there are files which match `patterns`. If there are matching files for any of the patterns,
* this function returns all `patterns`. Otherwise, `undefined` is returned.
Expand Down Expand Up @@ -158,7 +169,7 @@ const defaultCacheConfigs: { [language: string]: CacheConfig } = {
]),
},
csharp: {
getDependencyPaths: () => [join(os.homedir(), ".nuget", "packages")],
getDependencyPaths: getCsharpDependencyDirs,
getHashPatterns: getCsharpHashPatterns,
},
go: {
Expand Down