Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9c39f0a
Bump actions/download-artifact from 5 to 6 in /.github/workflows
dependabot[bot] Oct 27, 2025
44aeac1
Merge branch 'main' into dependabot/github_actions/dot-github/workflo…
mbg Oct 28, 2025
8d50be3
Merge pull request #3245 from github/dependabot/github_actions/dot-gi…
henrymercer Oct 30, 2025
cbcb06a
Update changelog and version after v4.31.1
github-actions[bot] Oct 30, 2025
c7a5b09
Merge remote-tracking branch 'origin/main' into mergeback/v4.31.1-to-…
github-actions[bot] Oct 30, 2025
e781179
Rebuild
github-actions[bot] Oct 30, 2025
b2bffa6
Remove unused `console-log-level` dependency
henrymercer Oct 30, 2025
aab1c2f
Merge pull request #3253 from github/mergeback/v4.31.1-to-main-5fe9434c
henrymercer Oct 30, 2025
514ff4d
Merge pull request #3256 from github/henrymercer/resolve-bad-merge
henrymercer Oct 30, 2025
2a3599c
Run lightweight workflows on `ubuntu-slim`
henrymercer Oct 30, 2025
f0e9bf0
Make `isEnablementError` case-insensitive
mbg Oct 30, 2025
cc88437
Merge pull request #3257 from github/henrymercer/ubuntu-slim
henrymercer Oct 30, 2025
9576b5c
Merge pull request #3258 from github/mbg/enablement-errors/case-insen…
mbg Oct 30, 2025
752a642
Update changelog for v4.31.2
github-actions[bot] Oct 30, 2025
8a06050
Merge pull request #3259 from github/update-v4.31.2-9576b5cbe
mbg Oct 30, 2025
eb80a79
Revert "Update version and changelog for v3.31.1"
github-actions[bot] Oct 30, 2025
d149012
Revert "Rebuild"
github-actions[bot] Oct 30, 2025
b7257cd
Merge remote-tracking branch 'origin/releases/v4' into backport-v3.31…
github-actions[bot] Oct 30, 2025
e56b5ee
Update version and changelog for v3.31.2
github-actions[bot] Oct 30, 2025
3741885
Rebuild
github-actions[bot] Oct 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/analyze-action.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions lib/init-action-post.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions lib/init-action.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions lib/setup-codeql-action.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions lib/upload-lib.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions lib/upload-sarif-action.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 23 additions & 30 deletions src/api-client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,37 +171,30 @@ test("wrapApiConfigurationError correctly wraps specific configuration errors",
);

// Enablement errors.
const codeSecurityNotEnabledError = new util.HTTPError(
const enablementErrorMessages = [
"Code Security must be enabled for this repository to use code scanning",
403,
);
res = api.wrapApiConfigurationError(codeSecurityNotEnabledError);
t.deepEqual(
res,
new util.ConfigurationError(
api.getFeatureEnablementError(codeSecurityNotEnabledError.message),
),
);
const advancedSecurityNotEnabledError = new util.HTTPError(
"Advanced Security must be enabled for this repository to use code scanning",
403,
);
res = api.wrapApiConfigurationError(advancedSecurityNotEnabledError);
t.deepEqual(
res,
new util.ConfigurationError(
api.getFeatureEnablementError(advancedSecurityNotEnabledError.message),
),
);
const codeScanningNotEnabledError = new util.HTTPError(
"Code Scanning is not enabled for this repository. Please enable code scanning in the repository settings.",
403,
);
res = api.wrapApiConfigurationError(codeScanningNotEnabledError);
t.deepEqual(
res,
new util.ConfigurationError(
api.getFeatureEnablementError(codeScanningNotEnabledError.message),
),
);
];
const transforms = [
(msg: string) => msg,
(msg: string) => msg.toLowerCase(),
(msg: string) => msg.toLocaleUpperCase(),
];

for (const enablementErrorMessage of enablementErrorMessages) {
for (const transform of transforms) {
const enablementError = new util.HTTPError(
transform(enablementErrorMessage),
403,
);
res = api.wrapApiConfigurationError(enablementError);
t.deepEqual(
res,
new util.ConfigurationError(
api.getFeatureEnablementError(enablementError.message),
),
);
}
}
});
6 changes: 3 additions & 3 deletions src/api-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,9 @@ export async function getRepositoryProperties(repositoryNwo: RepositoryNwo) {

function isEnablementError(msg: string) {
return [
/Code Security must be enabled/,
/Advanced Security must be enabled/,
/Code Scanning is not enabled/,
/Code Security must be enabled/i,
/Advanced Security must be enabled/i,
/Code Scanning is not enabled/i,
].some((pattern) => pattern.test(msg));
}

Expand Down
Loading