Skip to content

Support non-lock files for C# cache key computation #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 16 commits into from
Nov 12, 2025
Merged

Support non-lock files for C# cache key computation #3117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1ca20ab
Add `CsharpNewCacheKey` FF
mbg Sep 17, 2025
2aa1f55
Propagate `features` into `cachePrefix` function
mbg Sep 17, 2025
2a7680f
Change `getDefaultCacheConfig` to be a `const` by turning `paths` int…
mbg Sep 17, 2025
ab1c842
Change `hash` to be a function that can use `Features`
mbg Sep 17, 2025
6b48207
Move check whether there are files for hashing into `getHashPatterns`
mbg Sep 17, 2025
0324490
Use additional files for C# key hashes if `Feature.CsharpNewCacheKey`…
mbg Sep 17, 2025
0cbd930
Move `createCacheKeyHash` to `caching-utils`
mbg Nov 5, 2025
03b2dc2
Add and use `getFeaturePrefix` for dependency caching
mbg Nov 5, 2025
2680455
Use `undefined` instead of `NoMatchingFilesError`
mbg Nov 5, 2025
46e03b4
Fix JSDoc param name
mbg Nov 9, 2025
71abac7
Fix comment in `getCsharpHashPatterns`
mbg Nov 9, 2025
35c91ef
Add tests for `getCsharpHashPatterns`
mbg Nov 9, 2025
b0e9dfc
Restore missing `status.push` resulting from a bad merge
mbg Nov 9, 2025
a47d550
Restore earlier log messages for `checkHashPatterns`
mbg Nov 9, 2025
4885eb2
Insert new `featurePrefix` after general cache key `prefix`
mbg Nov 9, 2025
48a56f6
Add some tests for `downloadDependencyCaches` related to feature pref…
mbg Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Insert new featurePrefix after general cache key prefix
  • Loading branch information
@mbg
mbg committed Nov 9, 2025
commit 4885eb2ad9dd519f35db3ab42db9ca66b2ea3619
6 changes: 5 additions & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions src/dependency-caching.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,14 @@ async function cachePrefix(
// experimental features that affect the cache contents.
const featurePrefix = await getFeaturePrefix(codeql, features, language);

// Assemble the cache key.
return `${featurePrefix}${prefix}-${CODEQL_DEPENDENCY_CACHE_VERSION}-${runnerOs}-${language}-`;
// Assemble the cache key. For backwards compatibility with the JAR minification experiment's existing
// feature prefix usage, we add that feature prefix at the start. Other feature prefixes are inserted
// after the general CodeQL dependency cache prefix.
if (featurePrefix === "minify-") {
return `${featurePrefix}${prefix}-${CODEQL_DEPENDENCY_CACHE_VERSION}-${runnerOs}-${language}-`;
} else {
return `${prefix}-${featurePrefix}${CODEQL_DEPENDENCY_CACHE_VERSION}-${runnerOs}-${language}-`;
}
}

/** Represents information about our overall cache usage for CodeQL dependency caches. */
Expand Down
Loading