Skip to content

Fetch proxy binaries from defaults.json release #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 3 commits into from
Sep 12, 2025
Merged

Fetch proxy binaries from defaults.json release #3110

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffcbb4c
Move `UPDATEJOB_PROXY` constants to `start-proxy.ts`
mbg Sep 11, 2025
9df2342
Search release pointed at by `defaults.json` for registry proxy artifact
mbg Sep 11, 2025
e2636d2
Change "current release" to "linked release"
mbg Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Move UPDATEJOB_PROXY constants to start-proxy.ts
  • Loading branch information
@mbg
mbg committed Sep 11, 2025
commit ffcbb4c0c106f3f2c218ed4400e45ae5dd1ae3b7
6 changes: 3 additions & 3 deletions lib/start-proxy-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions src/start-proxy-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ import { pki } from "node-forge";

import * as actionsUtil from "./actions-util";
import { getActionsLogger, Logger } from "./logging";
import { Credential, getCredentials } from "./start-proxy";
import {
Credential,
getCredentials,
UPDATEJOB_PROXY,
UPDATEJOB_PROXY_URL_PREFIX,
UPDATEJOB_PROXY_VERSION,
} from "./start-proxy";
import * as util from "./util";

const UPDATEJOB_PROXY = "update-job-proxy";
const UPDATEJOB_PROXY_VERSION = "v2.0.20250624110901";
const UPDATEJOB_PROXY_URL_PREFIX =
"https://github.com/github/codeql-action/releases/download/codeql-bundle-v2.22.0/";
const KEY_SIZE = 2048;
const KEY_EXPIRY_YEARS = 2;

Expand Down
5 changes: 5 additions & 0 deletions src/start-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ import { KnownLanguage } from "./languages";
import { Logger } from "./logging";
import { ConfigurationError, isDefined } from "./util";

export const UPDATEJOB_PROXY = "update-job-proxy";
export const UPDATEJOB_PROXY_VERSION = "v2.0.20250624110901";
export const UPDATEJOB_PROXY_URL_PREFIX =
"https://github.com/github/codeql-action/releases/download/codeql-bundle-v2.22.0/";
Comment on lines +10 to +12
Copy link
Copy Markdown
Contributor

@henrymercer henrymercer Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Rename to include _FALLBACK_?

Copy link
Copy Markdown
Member Author

@mbg mbg Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to bother, since we can hopefully just remove the fallback logic once the next CodeQL CLI release has happened?


export type Credential = {
type: string;
host?: string;
Expand Down