Skip to content

Add a feature flag to use a bundle compressed using Zstandard when setting up the default tools #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 16 commits into from
Sep 27, 2024
Merged

Add a feature flag to use a bundle compressed using Zstandard when setting up the default tools #2502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e7309d2
Add feature flag for using zstd bundle
henrymercer Sep 23, 2024
ac3fca3
Use zstd bundle by default when feature flag enabled
henrymercer Sep 23, 2024
990feb5
Catch gotcha in PR check workflow generator
henrymercer Sep 23, 2024
b1ca017
Add PR check for zstd bundle
henrymercer Sep 23, 2024
db98c27
Gate zstd enablement on tar version
henrymercer Sep 23, 2024
a7a6a69
Determine zstd availability earlier on to simplify log
henrymercer Sep 23, 2024
662c71a
Check telemetry in PR check to ensure .tar.zst downloaded
henrymercer Sep 23, 2024
4d015b8
Fall back to gzip if zstd fails
henrymercer Sep 23, 2024
0abc1ec
Capture reason if zstd fails unexpectedly
henrymercer Sep 23, 2024
20bd6fe
Merge branch 'main' into henrymercer/zstd-experiment
henrymercer Sep 23, 2024
37309b9
Add changelog note
henrymercer Sep 23, 2024
fa91789
Run zstd checks against all operating systems
henrymercer Sep 24, 2024
67b30f7
Tweak description
henrymercer Sep 24, 2024
bc68dc9
Extract constant for first std-compressed version
henrymercer Sep 24, 2024
af8e2bc
Use Node script to remove CodeQL cross-platform
henrymercer Sep 24, 2024
6b2f7e7
Run PR checks using JS only
henrymercer Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run PR checks using JS only
  • Loading branch information
@henrymercer
henrymercer committed Sep 24, 2024
commit 6b2f7e7c28404627554332e4fe1880c5be10639c
10 changes: 3 additions & 7 deletions .github/workflows/__zstd-bundle-fallback.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 3 additions & 7 deletions .github/workflows/__zstd-bundle.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 3 additions & 7 deletions pr-checks/checks/zstd-bundle-fallback.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,8 @@ steps:
- id: init
uses: ./../action/init
with:
# Swift is not supported on Ubuntu so we manually exclude it from the list here
languages: cpp,csharp,go,java,javascript,python,ruby
languages: javascript
tools: ${{ steps.prepare-test.outputs.tools-url }}
- name: Build code
shell: bash
run: ./build.sh
- uses: ./../action/analyze
with:
output: ${{ runner.temp }}/results
Expand All @@ -35,12 +31,12 @@ steps:
uses: actions/upload-artifact@v3
with:
name: zstd-bundle.sarif
path: ${{ runner.temp }}/results/cpp.sarif
path: ${{ runner.temp }}/results/javascript.sarif
retention-days: 7
- name: Check expected diagnostics
uses: actions/github-script@v7
env:
SARIF_PATH: ${{ runner.temp }}/results/cpp.sarif
SARIF_PATH: ${{ runner.temp }}/results/javascript.sarif
with:
script: |
const fs = require('fs');
Expand Down
10 changes: 3 additions & 7 deletions pr-checks/checks/zstd-bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,8 @@ steps:
- id: init
uses: ./../action/init
with:
# Swift is not supported on Ubuntu so we manually exclude it from the list here
languages: cpp,csharp,go,java,javascript,python,ruby
languages: javascript
tools: ${{ steps.prepare-test.outputs.tools-url }}
- name: Build code
shell: bash
run: ./build.sh
- uses: ./../action/analyze
with:
output: ${{ runner.temp }}/results
Expand All @@ -34,12 +30,12 @@ steps:
uses: actions/upload-artifact@v3
with:
name: zstd-bundle.sarif
path: ${{ runner.temp }}/results/cpp.sarif
path: ${{ runner.temp }}/results/javascript.sarif
retention-days: 7
- name: Check diagnostic with expected tools URL appears in SARIF
uses: actions/github-script@v7
env:
SARIF_PATH: ${{ runner.temp }}/results/cpp.sarif
SARIF_PATH: ${{ runner.temp }}/results/javascript.sarif
with:
script: |
const fs = require('fs');
Expand Down