Skip to content

Send overall job status in init-post status report #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 17 commits into from
Jan 26, 2024
Merged

Send overall job status in init-post status report #2097

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
dbd8ad5
Send overall job status in init-post status report
angelapwen Jan 24, 2024
42cc9a3
Also set job status to failure if analyze didn't succeed
angelapwen Jan 24, 2024
0af1cd9
Set job status to success if analyze succeeded
angelapwen Jan 24, 2024
8b31be2
Remove debug print statement
angelapwen Jan 24, 2024
dd51ee0
Consider unsuccessful analysis in non-Action step config error
angelapwen Jan 24, 2024
2dd6a5b
Print debug statement
angelapwen Jan 24, 2024
da42b5b
Remove print statement again
angelapwen Jan 24, 2024
7daa052
Address PR review comments
angelapwen Jan 25, 2024
757ff40
Update comment
angelapwen Jan 25, 2024
c97e81c
Update documentation
angelapwen Jan 25, 2024
d1c63dc
Set job failure if action aborted
angelapwen Jan 25, 2024
14205b0
Update transpiled files
angelapwen Jan 25, 2024
8f47a57
Group conditions
angelapwen Jan 25, 2024
0429e3d
Appease linter
angelapwen Jan 25, 2024
f0dbc07
Actually call getFinalJobStatus()
angelapwen Jan 25, 2024
c2df72d
Remove unused imports
angelapwen Jan 25, 2024
f05e32e
Update comment on `aborted`
angelapwen Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment 
Co-authored-by: Henry Mercer <henry@henrymercer.name>
  • Loading branch information
@angelapwen @henrymercer
angelapwen and henrymercer authored Jan 25, 2024
commit 757ff40c35dfa91fc2f10a2dd7178668fdb8c1fb
3 changes: 2 additions & 1 deletion src/init-action-post-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ export async function tryUploadSarifIfRunFailed(
// If analyze didn't complete successfully and the job status hasn't
// already been set to Failure/ConfigurationError previously, this
// means that something along the way failed in a step that is not
// owned by the Action. This is considered configuration error.
// owned by the Action, for example a manual build step. We
// consider this a configuration error.
core.exportVariable(
EnvVar.JOB_STATUS,
process.env[EnvVar.JOB_STATUS] ?? JobStatus.ConfigurationError,
Expand Down