Skip to content

Remove config parsing logic that is now implemented in the CLI #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 10 commits into from
Jan 5, 2024
Merged

Remove config parsing logic that is now implemented in the CLI #2062

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa98ec0
Remove CliConfigFileEnabled feature flag
henrymercer Jan 4, 2024
f53698b
Remove Action-config code path in `runQueries`
henrymercer Jan 4, 2024
b683173
Remove unused arguments
henrymercer Jan 4, 2024
b30262c
Remove functionality for checking out external repos
henrymercer Jan 4, 2024
f934b28
Populate path filters env variables using the CLI
henrymercer Jan 4, 2024
f65fc6a
Remove parsing of `queries`, `packs`, `paths`, and `pathsIgnore`
henrymercer Jan 4, 2024
4feb32a
Remove code to download packs
henrymercer Jan 4, 2024
67be7bc
Remove unused status report fields
henrymercer Jan 4, 2024
d7437a2
Remove deprecated `CODEQL_PASS_CONFIG_TO_CLI` env var from PR checks
henrymercer Jan 4, 2024
a533ec6
Merge branch 'main' into henrymercer/remove-action-config-parsing
henrymercer Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove deprecated CODEQL_PASS_CONFIG_TO_CLI env var from PR checks
  • Loading branch information
@henrymercer
henrymercer committed Jan 4, 2024
commit d7437a2202142d374eba5c6ce3626e2ebd8458df
1 change: 0 additions & 1 deletion .github/workflows/__config-export.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions .github/workflows/__packaging-codescanning-config-inputs-js.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions .github/workflows/codescanning-config-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
name: Code-Scanning config CLI tests
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CODEQL_PASS_CONFIG_TO_CLI: true

on:
push:
Expand Down Expand Up @@ -204,15 +203,3 @@ jobs:
packs: + codeql/javascript-queries
config-file-test: .github/codeql/other-config-properties.yml
tools: ${{ steps.prepare-test.outputs.tools-url }}

- name: Config not generated when env var is not set
if: success() || failure()
env:
CODEQL_PASS_CONFIG_TO_CLI: false
uses: ./../action/.github/actions/check-codescanning-config
with:
expected-config-file-contents: ""
languages: javascript
packs: + codeql/javascript-queries
config-file-test: .github/codeql/other-config-properties.yml
tools: ${{ steps.prepare-test.outputs.tools-url }}
2 changes: 0 additions & 2 deletions pr-checks/checks/config-export.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: "Config export"
description: "Tests that the code scanning configuration file is exported to SARIF correctly."
versions: ["latest", "nightly-latest"]
env:
CODEQL_PASS_CONFIG_TO_CLI: true
steps:
- uses: ./../action/init
with:
Expand Down
4 changes: 0 additions & 4 deletions pr-checks/checks/packaging-codescanning-config-inputs-js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: "Packaging: Config and input passed to the CLI"
description: "Checks that specifying packages using a combination of a config file and input to the Action works"
versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with old CLIs

env:
CODEQL_PASS_CONFIG_TO_CLI: true

steps:
- uses: ./../action/init
with:
Expand Down