Swift: put all the PCM traps into the same place#9920
Merged
Conversation
redsun82
reviewed
Jul 29, 2022
Contributor
redsun82
left a comment
There was a problem hiding this comment.
I was trying this out myself 😄 I would just put some more explanation in the comment, otherwise I'm ok with merging this!
Comment on lines
+59
to
+60
| // Several modules with different name might come from .pcm (clang module) files | ||
| // In this case we want to differentiate them |
Contributor
There was a problem hiding this comment.
this does not explain why we strip the directory. We should probably say pcm files come from caches that might be located in different places, but are unambigouously identified by the base filename
Contributor
There was a problem hiding this comment.
I need to rebase #9922 on this one any way, so we can maybe just merge this as it is and I'll update the comment in mine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes duplicated TRAPs for precompiled clang modules.