Ensure the <lang>-lgtm-full.qls suites include definitions.ql queries#9835
Closed
aeisenberg wants to merge 1 commit into
Closed
Ensure the <lang>-lgtm-full.qls suites include definitions.ql queries#9835aeisenberg wants to merge 1 commit into
aeisenberg wants to merge 1 commit into
Conversation
In #9744, these queries were moved from `src` to `lib`. Now they are no longer part of the <lang>-full-suite.qls, so these suites need to be expanded to include them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9744, these queries were moved from
srctolib. Now they areno longer part of the -full-suite.qls, so these suites need to
be expanded to include them.
Please make sure that the new suite instruction should go before the
excludeinstruction. This will ensure thatide-contextual-queries/local-definitionsandide-contextual-queries/local-referencesare excluded. I think that's what we want.